Move CreateSession from advanced into basic options

[cgranleese-r7]

This PR moves the CreateSession option from advanced into basic options, in order to increase discoverability.

I have left have the default as true within the mixin, but added an option within each session types login module to override this options to be false:

• auxiliary/scanner/smb/smb_login
• auxiliary/scanner/mssql/mssql_login
• auxiliary/scanner/postgres/postgres_login
• auxiliary/scanner/mysql/mysql_login

As part of the ticket I was asked to do data mining to get a list of other modules that made use of this options. So it can be reviewed at module hacking or similar, just to get more input on potentially unexpected issues with this change:

• modules/auxiliary/cloud/aws/enum_ssm.rb
• modules/auxiliary/scanner/mysql/mysql_login.rb
• modules/auxiliary/scanner/postgres/postgres_login.rb
• modules/auxiliary/scanner/rservices/rexec_login.rb
• modules/auxiliary/scanner/rservices/rlogin_login.rb
• modules/auxiliary/scanner/rservices/rsh_login.rb
• modules/auxiliary/scanner/smb/smb_login.rb
• modules/auxiliary/scanner/ssh/eaton_xpert_backdoor.rb
• modules/auxiliary/scanner/ssh/fortinet_backdoor.rb
• modules/auxiliary/scanner/ssh/libssh_auth_bypass.rb
• modules/auxiliary/scanner/ssh/ssh_login.rb
• modules/auxiliary/scanner/ssh/ssh_login_pubkey.rb
• modules/auxiliary/scanner/telnet/brocade_enable_login.rb
• modules/auxiliary/scanner/telnet/telnet_login.rb
• modules/auxiliary/scanner/winrm/winrm_login.rb
• modules/exploits/windows/smb/smb_relay.rb

Verification

• Start msfconsole
• Use each new session type login module - use scanner/postgres/postgres_login
• Verify the CreateSession option is now present when running the options command.
• Verify the CreateSession option is no longer present when running the advanced command.
• Verify the login modules still function as expected
• Verify the module in the list of other modules that make use of the CreateSession options still have access to it and it defaults to true

[adfoster-r7]

Release Notes

Moves the CreateSession option from advanced into basic options for modules, in order to increase discoverability