Fixes the create session datastore option from appearing for payloads #18873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranleese-r7
force-pushed
the
fix-create-session-datastore-option-appearing-for-payloads
branch
from
e5a224b
to
9ddbd89
Compare
adfoster-r7
reviewed
Feb 22, 2024
cgranleese-r7
force-pushed
the
fix-create-session-datastore-option-appearing-for-payloads
branch
from
9ddbd89
to
d52220c
Compare
Release NotesFixes a regression that caused a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a a previous PR the
CreateSessionoptions was moved from the advanced options into the basic options. Previously it was not as apparent an issue as it was hidden with the advanced options, whereas now it was being displayed with the module options.The fix is to update how the create session options is being include in modules. Previously
Msf::Auxiliary::CommandShellmixin would includeinclude Msf::Sessions::CommandShellOptionswhich added theCreateSessionoption, which caused theCreateSessionoption to appear in the payload options.This has now been moved into it's own mxin, so we have more control over where it is added.
Verification
msfconsoleCreateSessionin the module optionsMsf::Auxiliary::CommandShellno longer have theCreateSessionoptions appearing with the payload options.