Expose MSSQL initial connection info in client #18863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanusz-r7
force-pushed
the
mssql-get-db-from-server
branch
2 times, most recently
from
aecb5de
to
814cc81
Compare
adfoster-r7
reviewed
Feb 20, 2024
adfoster-r7
changed the title
sjanusz-r7
force-pushed
the
mssql-get-db-from-server
branch
2 times, most recently
from
33c3e7e
to
48e749a
Compare
sjanusz-r7
force-pushed
the
mssql-get-db-from-server
branch
from
48e749a
to
200d03c
Compare
Docker -
|
cgranleese-r7
approved these changes
Feb 20, 2024
Release NotesThis PR adds in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the ENVCHANGE types to the MSSQL client mixin, and uses those to fetch the initial DB name received from the server. This data is stored as the
initial_connection_info.The prompt still calls off to
def format_prompt(val)->database_name->session.client.mssql_query('SELECT DB_NAME();')[:rows][0][0], but this will be changed in a future PR that will ensure all SQL session prompts are updated when the user connects to a different database usingquery.For context, this
initial_connection_infohas previously been discussed here: #18747 (comment)Verification
msfconsoleuse mssql_login