Normalize on single quotes, msftidy error #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2014 13:20
There is no need to have double quotes there for uninterpolated strings, and every other module uses single quotes.
msftidy should have defintely caught this. That it didn't catch on Travis-CI concerns me. Need to research this.
|
I've wanted to switch to using single quotes by default for all my code (other languages, too), but I'm kinda stuck on double quotes, since I don't have to think when I interpolate (which I do a lot). There are a few downsides to my current approach, of course. |
wvu
added a commit
to wvu/metasploit-framework
that referenced
this pull request
Jun 12, 2014
3 tasks
|
(To be fair, I got my current practice from C.) |
OJ
added a commit
that referenced
this pull request
Jun 24, 2014
todb-r7
pushed a commit
to todb-r7/metasploit-framework
that referenced
this pull request
Jun 29, 2014
This reverts commit 9b35b0e. This should not land on master until the Metasploit Pro folks (@trosen-r7 and friends) get their Meterpreter path specifications working the same way as Framework's does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up two recent module submissions, the Chromecast module (PR #3438) and the MongoDB module (PR #3430). These changes shouldn't cause any change in normal functionality -- the first is just to favor single quotes over double in the
initializemethod (and thesend_request_rawcalls), and the second is to correct a msftidy warning.Verification