-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the revert of #3466 (Meterpreter binaries gem) #3481
Conversation
This would have made lots of people uhnappy.
This reverts commit 9b35b0e. This should not land on master until the Metasploit Pro folks (@trosen-r7 and friends) get their Meterpreter path specifications working the same way as Framework's does.
Capital idea. I'll merge to my branch when I'm near a proper terminal. |
This incoporates @OJ's fixes as a result of gemification.
+1. Love your work @todb-r7 |
Needs resolving against upstream again... Whats the timescale on this? :) |
Man I suck at resolving merge conflicts. |
Conflicts: Gemfile.lock
@Meatballs1 My own Metasploit Pro development environment is old and dusty and I'm not up to speed quite yet, which is the holdup here. I can't propose a fix to Pro without getting my dev ducks in a row. That's all nearly sorted now so I should have something together shortly. |
Okay, I have a fix in that @kgray-r7 is testing now, on the Metepreter Pro source. Initial smoke testing seems to say this is a-ok. |
Adding @jlee-r7 as the assignee since he can handle both the Pro (and tell me what I did wrong) as well as the Framework sides. |
Why do these binaries still live in framework instead of the gem? https://github.com/todb-r7/metasploit-framework/tree/reintroduce-meterpreter-gems/data/meterpreter Sorry if this has been covered before. I'm a bit late to the party. |
Trying to move the base Windows stuff first. Once that lands (and doesn't get reverted) we can start moving over bins over. Just trying to do it in stages. |
@jlee-r7 intimated he woudl land this Monday right after release cut so we could have a few days of it without impacting release schedules. |
This reverts commit 9b35b0e.
This should not land on master until the Metasploit Pro folks (@trosen-r7 and friends) get their Meterpreter path specifications working the same way as Framework's does. IOW, one of those folks should land this.
See #3466 for details. (The commit message mistakenly mentions #3446)