Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force MDM to 0.17.4 as 0.17.5 breaks things #3495

Closed
wants to merge 1 commit into from

Conversation

hdm
Copy link
Contributor

@hdm hdm commented Jul 6, 2014

This is breaking new source-based installations with the following error:

ruby-1.9.3-p547@metasploit-framework/bundler/gems/metasploit_data_models-0b1fc5baf50c/app/models/metasploit_data_models/search/operator/multitext.rb:5:in `<top (required)>': uninitialized constant MetasploitDataModels::Search::Operator (NameError)

Fix MDM or merge this, either way.

This is breaking new source-based installations
@hdm
Copy link
Contributor Author

hdm commented Jul 6, 2014

Testing from buddha indicated that unless bundle update is executed, something between 0.17.1 and 0.17.4 also fails to indicate that it needs metasploit/concern. Looks like the various MDM + MSF Gemfile minimum versions weren't being enforced. For anyone watching this bug, run bundle update if you get an issue about metasploit/concerns or change this back to 0.17.1

@limhoff-r7
Copy link
Contributor

(now as the right account)

The Gemfile.lock locks metasploit_data_models at 0.17.0 on
metasploit-framework/master
. They should only be hitting this bug if they
are doing bundle update instead of bundle install and we don't support
people bundle updating because that updates all dependencies in the lock file, not just grab the dependencies you are missing. We use a Gemfile.lock so we don't have to ensure
that we work with the latest and greatest of all our dependencies and to ensure the tested gems are the same as the gems users get as is standard practice for Ruby applications. (gems on the other hand don't use Gemfile.lock because only *.gemspec dependencies are propagated for gems)

Yes, there is a bug in that 0.17.4 should be 0.18.0, but no one should hit
it unless they are mistakenly doing bundle update instead of bundle install.

@limhoff-r7
Copy link
Contributor

Opened bug to fix mdm's version as MSP-10654. This can be closed because I'll yank 0.17.4-0.17.6 from rubygems.org and master will become 0.18.0 to signal the incompatibility.

@limhoff-r7 limhoff-r7 closed this Jul 7, 2014
hdm pushed a commit to hdm/metasploit-framework that referenced this pull request Jul 7, 2014
@hdm hdm deleted the bug/lock-mdm-at-0-17-4 branch July 7, 2014 15:48
@ZeroChaos-
Copy link
Contributor

is locking to 0.17.0 really correct? it doesn't work with 0.17.1-0.17.3?

bturner-r7 added a commit to bturner-r7/metasploit-framework that referenced this pull request Jul 9, 2014
Several incompatible 0.17 MDM versions were released that required us to
pin MDM in framework.  The incompatible versions have been yanked from
RubyGems.  This restores the original version range for MDM.

See rapid7#3495.

This reverts commit 8f39590.
@bturner-r7 bturner-r7 mentioned this pull request Jul 9, 2014
minaco2 pushed a commit to git-portage/git-portage that referenced this pull request Jul 10, 2014
(Portage version: 2.2.8-r1/cvs/Linux x86_64, signed Manifest commit with key DD11F94A)
minaco2 pushed a commit to git-portage/git-portage that referenced this pull request Jul 10, 2014
(Portage version: 2.2.8-r1/cvs/Linux x86_64, signed Manifest commit with key DD11F94A)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants