Add a Rubocop autoconfig

[todb-r7]

This excludes all the existing problems reported by Rubocop so that we don't get depressed by seeing every single module fail the check.

The goal is to at least prevent new classes of Rubocop errors from cropping up, and provide a TODO list of fixes to make across our giant code base.

Incidentally, this method of starting out with Rubocop is suggested in Rubocop's README.md.

CC @jhart-r7

[todb-r7]

I'm experimenting with this TODO now to see how painful it is to knock out some tasks with rubocop --only runs -- ideally, you'd want to tackle each offense in turn, now that you know where they are.

[jhart-r7]

I can't test this right now, but if this was committed and I added a new module/etc that is rife with style problems, what happens? Would rubocop flag it? Or only if the problems were not among the types of problems already present in existing code?

[todb]

It's per type, but not per file. Rubocop doesn't appear to have a syntax for "ignore this problem only in these files."

So, we have a zillion strings with double quotes that don't actually need double quotes, so if you add a few more, you will not trigger a warning.

Ruby style purity is a very long road.

Sent from a tiny computer.
PGP KeyId: 4096R/F577904A
https://gist.github.com/todb-r7/84ae2e08eb4dafbc4822
Text (insecure): 512-438-9165

[kernelsmith]

It’s already super fun when you have methods named after windows api data structs cuz you get a shit-ton of wrong case warnings. I’ve been letting it go if it’s strictly stuff like:

halDispatchTable = session.railgun.kernel32.GetProcAddress(hKernel, 'HalDispatchTable’)

tho I realize it could be enforced w/o real detriment. BTW, I’ve found this a handy technique for shortening and adding readability to long railgun calls

lp_image_base = %w(PBLOB lpImageBase out)
cb = %w(DWORD cb in)
lpcb_needed = %w(PDWORD lpcbNeeded out)
session.railgun.add_function('psapi', 'EnumDeviceDrivers', 'BOOL',
                                 [lp_image_base, cb, lpcb_needed])

credit to @zeroSteiner and/or @OJ on the idea of using %w

On Jul 29, 2014, at 7:03 PM, Tod Beardsley notifications@github.com wrote:

It's per type, but not per file. Rubocop doesn't appear to have a syntax for "ignore this problem only in these files."

So, we have a zillion strings with double quotes that don't actually need double quotes, so if you add a few more, you will not trigger a warning.

Ruby style purity is a very long road.

Sent from a tiny computer.
PGP KeyId: 4096R/F577904A
https://gist.github.com/todb-r7/84ae2e08eb4dafbc4822
Text (insecure): 512-438-9165
—
Reply to this email directly or view it on GitHub.