Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpaceBeforeModifierKeyword Rubocop warning #3588

Merged
merged 1 commit into from Aug 4, 2014

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Jul 29, 2014

This also deals with some errant tabs where internal spaces should be,
as well as one syntax error which was preventing an old meterpreter
script from ever working correctly.

Some day, we need to get rid of those Meterpeter scripts. Srsly.

This is an experiment as a result of #3587. It's a small test, dealing with only a few issues. This is not blocked by #3587 at all, but if this lands, the rubocop_todo.yml should be updated to stop ignoring SpaceBeforeModifierKeyword.

This also deals with some errant tabs where internal spaces should be,
as well as one syntax error which was preventing an old meterpreter
script from ever working correctly.

Some day, we need to get rid of those Meterpeter scripts. Srsly.
@jhart-r7
Copy link
Contributor

This   looks
   ok

@kernelsmith
Copy link
Contributor

LMFAO

On Jul 29, 2014, at 5:32 PM, Jon Hart notifications@github.com wrote:

This looks
ok

Reply to this email directly or view it on GitHub.

@jhart-r7 jhart-r7 merged commit adf03e2 into rapid7:master Aug 4, 2014
@todb-r7 todb-r7 deleted the rubocop/spacebeforemodifierkeyword branch November 25, 2014 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants