Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up titles, descriptions #4755

Merged
merged 4 commits into from Feb 12, 2015
Merged

Fix up titles, descriptions #4755

merged 4 commits into from Feb 12, 2015

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Feb 12, 2015

This fixes up some of the titles and descriptions in recently landed modules. Of special note, the string 'towelroot' is mentioned in the title of the Android futex bug (since it seems like a pretty likely keyword for searching), and the version number was dropped from the Achat module. Note the Achat module seemed to be erroneously described as a "stack overflow," one of @wchen-r7's favorite pet peeves.

Verification

  • See the new titles and descriptions make sense.

Avoiding this in the future

As Batman says,

Any android phone with a kernel built before June 2014 should be vulnerable.
This module exploits a bug in futex_requeue in the Linux kernel, using
similiar techniques employed by the towelroot exploit. Any Android device
with a kernel built before June, 2014 is likely to be vulnerable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/June, 2014/June 2014/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[citation needed]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

touche!

@todb-r7
Copy link
Author

todb-r7 commented Feb 12, 2015

Updated.

such as open file with write lock. Can be used to retrieve files such as NTDS.dit.),
such as open file with write lock. Because it avoids the usual file locking issues, it can
be used to retrieve files such as NTDS.dit.
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wvu added a commit to wvu/metasploit-framework that referenced this pull request Feb 12, 2015
@wvu wvu merged commit c156ed6 into rapid7:master Feb 12, 2015
@wvu
Copy link
Contributor

wvu commented Feb 12, 2015

Done!

todb-r7 pushed a commit to todb-r7/metasploit-framework that referenced this pull request Feb 12, 2015
Lots of onesy-twosies.

[ci skip]

Squashed commit of the following:

commit 09712ad530f14ccd4073b47c9c708b762aa4e0d7
Merge: c156ed6 d7fa06d
Author: Tod Beardsley <tod_beardsley@rapid7.com>
Date:   Thu Feb 12 13:16:15 2015 -0600

    Merge remote-tracking branch 'origin/pr/14' into fixup-release

commit d7fa06d
Author: William Vu <William_Vu@rapid7.com>
Date:   Thu Feb 12 13:01:30 2015 -0600

    Fix off-by-one whitespace

commit c156ed6
Author: Tod Beardsley <tod_beardsley@rapid7.com>
Date:   Thu Feb 12 12:56:53 2015 -0600

    on, not of.

commit e35f603
Author: Tod Beardsley <tod_beardsley@rapid7.com>
Date:   Thu Feb 12 12:49:45 2015 -0600

    Comma fascism

commit d89eda6
Author: Tod Beardsley <tod_beardsley@rapid7.com>
Date:   Thu Feb 12 12:46:38 2015 -0600

    Moar fixes, thanks @wvu-r7

    See rapid7#4755

commit e78d08e
Author: Tod Beardsley <tod_beardsley@rapid7.com>
Date:   Thu Feb 12 12:11:40 2015 -0600

    Fix up titles, descriptions
@todb-r7
Copy link
Author

todb-r7 commented Feb 12, 2015

aw i fixed the whitespace thing, too, and force-pushed.

@wvu
Copy link
Contributor

wvu commented Feb 12, 2015

Sorry for screwing up your branch. :X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants