Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up titles, descriptions #4755

Merged
merged 4 commits into from
Feb 12, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions modules/exploits/android/local/futex_requeue.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,17 @@ class Metasploit4 < Msf::Exploit::Local

def initialize(info={})
super( update_info( info, {
'Name' => 'Android Futex Requeue Kernel Exploit',
'Name' => "Android 'Towelroot' Futex Requeue Kernel Exploit",
'Description' => %q{
This module exploits a bug in futex_requeue in the linux kernel.
Any android phone with a kernel built before June 2014 should be vulnerable.
This module exploits a bug in futex_requeue in the Linux kernel, using
similiar techniques employed by the towelroot exploit. Any Android device
with a kernel built before June, 2014 is likely to be vulnerable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/June, 2014/June 2014/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[citation needed]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

touche!

},
'License' => MSF_LICENSE,
'Author' => [
'Pinkie Pie', #discovery
'geohot', #towelroot
'timwr' #metasploit module
'Pinkie Pie', # discovery
'geohot', # towelroot
'timwr' # metasploit module
],
'References' =>
[
Expand Down
9 changes: 5 additions & 4 deletions modules/exploits/windows/local/ms14_070_tcpip_ioctl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ class Metasploit3 < Msf::Exploit::Local

def initialize(info={})
super(update_info(info, {
'Name' => 'Windows tcpip!SetAddrOptions NULL Pointer Dereference',
'Name' => 'MS14-070 Windows tcpip!SetAddrOptions NULL Pointer Dereference',
'Description' => %q{
A vulnerability within the Microsoft TCP/IP protocol driver tcpip.sys,
can allow an attacker to trigger a NULL pointer dereference by using a
specially crafted IOCTL.
A vulnerability within the Microsoft TCP/IP protocol driver tcpip.sys
can allow a local attacker to trigger a NULL pointer dereference by using a
specially crafted IOCTL. This flaw can be abused to elevate privileges to
SYSTEM.
},
'License' => MSF_LICENSE,
'Author' =>
Expand Down
10 changes: 5 additions & 5 deletions modules/exploits/windows/misc/achat_bof.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ class Metasploit3 < Msf::Exploit::Remote

def initialize(info = {})
super(update_info(info,
'Name' => 'Achat v0.150 beta7 Buffer Overflow',
'Name' => 'Achat Stack Based Buffer Overflow',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Stack Based/Stack-Based/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ grep -r "Stack Based" modules | wc -l
4
[ruby-2.1.5](master) 
todb@mazikeen:~/git/rapid7/metasploit-framework$ grep -r "Stack-Based" modules | wc -l
0
[ruby-2.1.5](master) 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FINE. YOU WIN.

'Description' => %q{
This module exploits an unicode SEH based stack buffer overflow in Achat v0.150. By
sending a crafted message to the default port 9256 it's possible to overwrites the
SEH handler. Even when the exploit is reliable it depends of timing since there are
This module exploits a Unicode SEH based stack based buffer overflow in Achat. By
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/SEH based stack based/stack-based SEH/

sending a crafted message to the default port UDP/9256, it's possible to overwrite the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9256/UDP is the traditional format.

SEH handler. Even when the exploit is reliable, it depends of timing since there are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/of timing/on timing,/

two threads overflowing the stack in the same time. This module has been tested on
Windows XP SP3 and Windows 7.
Achat v0.150 running on Windows XP SP3 and Windows 7.
},
'Author' =>
[
Expand Down
3 changes: 2 additions & 1 deletion modules/post/windows/gather/file_from_raw_ntfs.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def initialize(info = {})
'Name' => 'Windows File Gather File from Raw NTFS',
'Description' => %q(
This module gathers a file using the raw NTFS device, bypassing some Windows restrictions
such as open file with write lock. Can be used to retrieve files such as NTDS.dit.),
such as open file with write lock. Because it avoids the usual file locking issues, it can
be used to retrieve files such as NTDS.dit.),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make the paren a brace, match it, and then drop it down a line to be more consistent with our other modules?

'License' => 'MSF_LICENSE',
'Platform' => ['win'],
'SessionTypes' => ['meterpreter'],
Expand Down