Update msfvenom #5027
Update msfvenom #5027
Conversation
Grammar and style.
|
Hi @DrDinosaur. As a rule we don't enforce punctuation on comments and we try to keep the line length of printed options smaller even at the cost of grammar. Some of these cosmetic updates look useful (comment sentence capitalization is nice), but others go against the intent (smaller line length in help output). Related are #5028 & #5026 |
| @@ -117,7 +117,7 @@ require 'msf/core/payload_generator' | |||
| opts[:keep] = true | |||
| end | |||
|
|
|||
| opt.on('--payload-options', "List the payload's standard options") do | |||
| opt.on('--payload-options', 'List the payload's standard options') do | |||
There was a problem hiding this comment.
Given the interior ' this will break formatting.
|
+1 to HD's comments -- I don't expect to spend a lot of effort fixing punctuation and caps in inline comments, especially non-YARD formatted comments, since it'll never really be consumed by an API reference doc or anything. I expect to pull in a couple of these changes, just trying to figure out the best/easiest way to land only a little of this PR with some creative merging, reverting, and |
Switching from " to ' is usually more trouble than it's worth, even if it's more technically correct. The original PR had a great example of that kind of error, where you accidentally screw up an interior apostraphe. [See rapid7#5027]
|
Note that the merged version now conflicts with this branch, @DrDinosaur you're free to delete the branch on your side. |
Grammar and style.