Fix check_conn? method in cisco_ironport_enum

[wvu]

#7611 (comment)
#7611 (comment)

[wvu]

I'm using explicit return statements because it looks weird without...

[wvu]

I'm not sure what the appropriate response code should be. Probably 200. I'm not sure it matters, since the check is already simplistic.

[pbarry-r7]

Verified on both a working/good target and when the target isn't there:

$ ./msfconsole
                                                  
 _                                                    _
/ \    /\         __                         _   __  /_/ __
| |\  / | _____   \ \           ___   _____ | | /  \ _   \ \
| | \/| | | ___\ |- -|   /\    / __\ | -__/ | || | || | |- -|
|_|   | | | _|__  | |_  / -\ __\ \   | |    | | \__/| |  | |_
      |/  |____/  \___\/ /\ \\___/   \/     \__|    |_\  \___\


       =[ metasploit v4.13.3-dev-777d5c1                  ]
+ -- --=[ 1605 exploits - 913 auxiliary - 275 post        ]
+ -- --=[ 458 payloads - 39 encoders - 9 nops             ]
+ -- --=[ Free Metasploit Pro trial: http://r-7.co/trymsp ]

msf > use auxiliary/scanner/http/cisco_ironport_enum
msf auxiliary(cisco_ironport_enum) > set RHOSTS 127.0.0.1
RHOSTS => 127.0.0.1
msf auxiliary(cisco_ironport_enum) > run

[+] 127.0.0.1:443 - Server is responsive...
[+] 127.0.0.1:443 - Running Cisco IronPort Security Management Appliances (SMA) - AsyncOS v10.2 
[*] 127.0.0.1:443 - Starting login brute force...
[*] 127.0.0.1:443 - [1/1] - Trying username:"admin" with password:"ironport"
[+] 127.0.0.1:443 - SUCCESSFUL LOGIN - "admin":"ironport"
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed

<I killed the IronPort emulation tool at this point to cause a failure>

msf auxiliary(cisco_ironport_enum) > run

[-] 127.0.0.1:443 - Connection failed, Aborting...
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed

[pbarry-r7]

Thanks, @wvu-r7!! 👍

[pbarry-r7]

No release notes needed.

[wvu]

For posterity, I was able to replicate a failure scenario in #7611 by closing ncat so that send_request_cgi returns nil.