Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #7640 where cisco SSL VPN not move despite server responded #7641

Merged
merged 1 commit into from Dec 1, 2016
Merged

Fix issue #7640 where cisco SSL VPN not move despite server responded #7641

merged 1 commit into from Dec 1, 2016

Conversation

jinq102030
Copy link
Contributor

@jinq102030 jinq102030 commented Nov 30, 2016 •
edited by wvu

Tell us what this change does. If you're fixing a bug, please mention
the github issue number.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use auxiliary/scanner/http/cisco_ssl_vpn
  • set RHOSTS 127.0.01
  • run
msf auxiliary(cisco_ssl_vpn) > run
[*] Reloading module...

[+] Server is responsive...
[+] Application appears to be Cisco SSL VPN. Module will continue.
[*] Attempt to Enumerate VPN Groups...
[!] Unable to enumerate groups
[!] Using the default group: DefaultWEBVPNGroup
[*] Starting login brute force...
[*] Trying username:"cisco" with password:"cisco" and group:"DefaultWEBVPNGroup"
[+] SUCCESSFUL LOGIN - "cisco":"cisco":"DefaultWEBVPNGroup"
[*] Trying username:"cisco" with password:"cisco" and group:""
[+] SUCCESSFUL LOGIN - "cisco":"cisco":""
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed

Add the "return true" statement that was missing.

@jinq102030
Fix issue rapid7#7640 where cisco SSL VPN not move despite server res…
ec83a86 
…ponded

Add the "return true" statement that was missing.
@jinq102030 jinq102030 mentioned this pull request Nov 30, 2016
Closed
wvu
wvu reviewed Dec 1, 2016
View reviewed changes
modules/auxiliary/scanner/http/cisco_ssl_vpn.rb
@@ -84,6 +84,7 @@ def check_conn?
begin
res = send_request_cgi('uri' => '/', 'method' => 'GET')
vprint_good("Server is responsive...")
return true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much like #7611 and #7622 that followed, is this the right fix? What if res is nil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was lazy again :-) and assumed it's ok to do it after "Server is responsive..." :-) Thanks for raising the question.

@wvu wvu self-assigned this Dec 1, 2016
@wvu wvu merged commit ec83a86 into rapid7:master Dec 1, 2016
wvu added a commit that referenced this pull request Dec 1, 2016
@wvu
Land #7641, check_conn? fix for cisco_ssl_vpn
54684d3
@wvu
Copy link
Contributor

wvu commented Dec 1, 2016

032312d

@wvu
Copy link
Contributor

wvu commented Dec 1, 2016 •
edited by tdoan-r7

Release Notes

This fix changes the check_conn? method in auxiliary/scanner/http/cisco_ssl_vpn to return the correct status in order to proceed with scanning.

@wvu
Copy link
Contributor

wvu commented Dec 1, 2016

@jinq102030: Feel free to label PRs you create. At least feature/bug and module/library should be sufficient.

@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvu wvu wvu left review comments

Assignees

@wvu wvu

Labels
bug module rn-fix release notes fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jinq102030 @wvu @tdoan-r7