Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge miniforge-cuda into ci-imgs #167

Merged
merged 11 commits into from
Aug 27, 2024
Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Aug 8, 2024

@hcho3 hcho3 requested a review from a team as a code owner August 8, 2024 00:26
@hcho3 hcho3 requested review from jameslamb and removed request for a team August 8, 2024 00:26
@hcho3 hcho3 changed the title [WIP] Merge miniforge-cuda into ci-imgs Merge miniforge-cuda into ci-imgs Aug 8, 2024
latest.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hyunsu! 🙏

Had a few minor suggestions below

.github/workflows/build-image.yaml Outdated Show resolved Hide resolved
ci-wheel.Dockerfile Outdated Show resolved Hide resolved
citestwheel.Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! Overall, this looks good to me I like the approach of sharing a single Dockerfile for ci-conda and miniforge-cuda.

Some things I checked, that are working well:

However, I see 2 things that should be changed:

Ensure intermediate images are getting cleaned up in rapidsai/staging: on DockerHub

I think maybe something is broken with the jobs that delete temporary images?

I still see lots of *-167-* images at https://hub.docker.com/r/rapidsai/staging/tags?page=&page_size=&ordering=&name=-167-. That 167 corresponds to the PR number here on GitHub.

In theory, I think those should be getting removed by this:

Could you please look into that?

This PR does not finish the work

This PR shouldn't say it "closes" the work to move miniforge-cuda into this repo. Once this is merged and a few days have gone by with no issues, there are a few other things I think need to be done to consider this work complete. I just put those up in a task list at rapidsai/build-planning#48.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, aside from @jameslamb's comments on intermediate image cleanup and follow-up tasks.

@@ -1,9 +1,17 @@
# Define the values used for the "latest" tag
conda:
miniforge-cuda:
CUDA_VER: "12.2.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update all these to 12.5. But that can be a follow-up PR.

@bdice bdice mentioned this pull request Aug 15, 2024
@bdice
Copy link
Contributor

bdice commented Aug 27, 2024

Ensure intermediate images are getting cleaned up in rapidsai/staging: on DockerHub

I think maybe something is broken with the jobs that delete temporary images?

#172 is handling this in the same way as rapidsai/docker#709.

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this PR look good and we should merge this. But please do see the other follow-up items I mentioned before we consider rapidsai/build-planning#48 complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants