Fix GHA warnings in diffs #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
changed the title
FROM & AS to fix GHA warnings
|
Thanks Bradley! 🙏 Honestly am having a hard time reviewing PRs because of these warnings. So wanted to speed up resolution. Hence addressing in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
*.Dockerfiles are getting flagged for warnings by GHA. However each time a job runs it gets flagged. So we get dozens of comments in the diffs, which makes reviewing PRs here difficultTo fix this issue this cleans up the common warnings we have seen
We may also want to separately consider only raising these warnings once so as to keep PR reviews manageable
Edit: For clarity these are the GHA warnings that I see currently. It takes quite a bit of scrolling to get through them all