Simplify version update script #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CHANGELOG is only updated for releases when the `main` branch is updated. So just reference that branch in the Changelog link on PyPI. That should cutdown on the version hard-coding and version updating as well.
As `python/cucim/docs` was dropped recently, there is nothing here to update. So remove it from the version update script.
jakirkham
commented
Feb 28, 2024
| @@ -37,15 +37,8 @@ sed_runner 's/release = .*/release = "'"${NEXT_FULL_TAG}"'"/g' docs/source/conf. | |||
| # Centralized version file update | |||
| echo "${NEXT_FULL_TAG}" > VERSION | |||
|
|
|||
| sed_runner "s#\[Version ${CURRENT_LONG_TAG}\](release_notes/v${CURRENT_LONG_TAG}.md)#\[Version ${NEXT_FULL_TAG}\](release_notes/v${NEXT_FULL_TAG}.md)#g" python/cucim/docs/index.md | |||
| sed_runner "s/v${CURRENT_LONG_TAG}/v${NEXT_FULL_TAG}/g" python/cucim/docs/getting_started/index.md | |||
| sed_runner "s#cucim.kit.cuslide@${CURRENT_LONG_TAG}.so#cucim.kit.cuslide@${NEXT_FULL_TAG}.so#g" python/cucim/docs/getting_started/index.md | |||
| sed_runner "s#cucim.kit.cuslide@${CURRENT_LONG_TAG}.so#cucim.kit.cuslide@${NEXT_FULL_TAG}.so#g" cucim.code-workspace | |||
There was a problem hiding this comment.
Wasn't sure if we were still using cucim.code-workspace. So left it alone
Asking if we still need it, in issue: #706
Edit: Gigon confirmed this is still in use
jakirkham
commented
Feb 28, 2024
| @@ -79,7 +79,7 @@ pip install cucim-cu11 | |||
|
|
|||
| ### Notebooks | |||
|
|
|||
| Please check out our [Welcome](notebooks/Welcome.ipynb) notebook ([NBViewer](https://nbviewer.jupyter.org/github/rapidsai/cucim/blob/branch-24.04/notebooks/Welcome.ipynb)) | |||
| Please check out our [Welcome](notebooks/Welcome.ipynb) notebook ([NBViewer](https://nbviewer.org/github/rapidsai/cucim/blob/main/notebooks/Welcome.ipynb)) | |||
There was a problem hiding this comment.
This redirects to nbviewer.org. So just used that
Went to the URL to confirm the notebook loaded correctly
jakirkham
commented
Feb 28, 2024
Comment on lines
-40
to
-42
| sed_runner "s#\[Version ${CURRENT_LONG_TAG}\](release_notes/v${CURRENT_LONG_TAG}.md)#\[Version ${NEXT_FULL_TAG}\](release_notes/v${NEXT_FULL_TAG}.md)#g" python/cucim/docs/index.md | ||
| sed_runner "s/v${CURRENT_LONG_TAG}/v${NEXT_FULL_TAG}/g" python/cucim/docs/getting_started/index.md | ||
| sed_runner "s#cucim.kit.cuslide@${CURRENT_LONG_TAG}.so#cucim.kit.cuslide@${NEXT_FULL_TAG}.so#g" python/cucim/docs/getting_started/index.md |
There was a problem hiding this comment.
We dropped all of these in PR: #666
So no need to update versions here any more. Hence they are dropped
jakirkham
commented
Feb 28, 2024
| @@ -24,7 +24,6 @@ rapids-mamba-retry install \ | |||
| --channel "${PYTHON_CHANNEL}" \ | |||
| cucim libcucim | |||
|
|
|||
| export RAPIDS_VERSION_NUMBER="24.04" | |||
There was a problem hiding this comment.
This wasn't used anywhere. So just removed it
Always possible to add it back whenever we need it again
jakirkham
commented
Feb 28, 2024
| @@ -5,9 +5,9 @@ | |||
|
|
|||
| set -euo pipefail | |||
|
|
|||
| . /opt/conda/etc/profile.d/conda.sh | |||
| RAPIDS_VERSION_NUMBER=$(rapids-generate-version) | |||
There was a problem hiding this comment.
Other RAPIDS libraries get the current version by running this script
So doing the same thing here
jakirkham
added
non-breaking
|
Failures on Python 3.11 are expected and can be ignored This will be handled by PR: #704 |
raydouglass
approved these changes
Feb 29, 2024
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch in links as that is updated every releasexref: rapidsai/build-planning#15