Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old ci and docs subfolders and related files under python/cucim #666

Merged
merged 11 commits into from
Dec 15, 2023

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Dec 13, 2023

closes #659
closes #660
closes #661

@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change maintenance labels Dec 13, 2023
@grlee77 grlee77 added this to the v24.02.00 milestone Dec 13, 2023
@grlee77 grlee77 requested review from a team as code owners December 13, 2023 17:43
@ajschmidt8 ajschmidt8 mentioned this pull request Dec 13, 2023
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @grlee77 for pushing this cleanup changes!
I have a question on two file deletions that might be used by MANIFEST.in file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid if AUTHORS.md and CONTRIBUTING.md files are used by MANIFEST.in file.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I also see some others like .cookiecutterrc, etc. that should be removed.

Also forgot to remove the .readthedocs.yml file

raydouglass pushed a commit that referenced this pull request Dec 13, 2023
This PR updates the `CODEOWNERS` file to ensure that the Ops team doesn't get tagged for files that we're not concerned with.

This should prevent PRs like the following from soliciting us for approvals:

- #665
- #666

[skip ci]

Authors:
   - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
   - Ray Douglass (https://github.com/raydouglass)
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grlee77 ! Looks good to me besides a question in MANIFEST.in

python/cucim/MANIFEST.in Show resolved Hide resolved
@gigony
Copy link
Contributor

gigony commented Dec 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit ee30868 into rapidsai:branch-24.02 Dec 15, 2023
39 checks passed
rapids-bot bot pushed a commit that referenced this pull request Feb 29, 2024
* Drop version update steps for doc pages that no longer exist: #666
* Use the `main` branch in links as that is updated every release

xref: rapidsai/build-planning#15

Authors:
  - https://github.com/jakirkham

Approvers:
  - Gregory Lee (https://github.com/grlee77)
  - Ray Douglass (https://github.com/raydouglass)

URL: #705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality maintenance non-breaking Introduces a non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Review & cleanup python/cucim Cleanup python/cucim/ci Cleanup python/cucim/docs
4 participants