Skip to content

Commit

Permalink
Followup to PR 9088 comments (#9659)
Browse files Browse the repository at this point in the history
These are some minor updates requested for PR #9088 that I forgot to push prior to merging the PR.

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)

URL: #9659
  • Loading branch information
cwharris authored Nov 11, 2021
1 parent ba2b51d commit 36b3344
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
13 changes: 4 additions & 9 deletions cpp/include/cudf/io/detail/json.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@
* limitations under the License.
*/

/**
* @file json.hpp
* @brief cuDF-IO reader classes API
*/

#pragma once

#include <cudf/io/json.hpp>
Expand All @@ -33,10 +28,10 @@ namespace json {
/**
* @brief Reads and returns the entire data set.
*
* @param[in] sources Input `datasource` objects to read the dataset from
* @param[in] options Settings for controlling reading behavior
* @param[in] stream CUDA stream used for device memory operations and kernel launches
* @param[in] mr Device memory resource to use for device memory allocation
* @param sources Input `datasource` objects to read the dataset from
* @param options Settings for controlling reading behavior
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource to use for device memory allocation
*
* @return cudf::table object that contains the array of cudf::column.
*/
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/io/json/reader_impl.cu
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ std::pair<std::vector<std::string>, col_map_ptr_type> get_column_names_and_map(
rmm::cuda_stream_view stream)
{
// If file only contains one row, use the file size for the row size
uint64_t first_row_len = d_data.size() / sizeof(char);
uint64_t first_row_len = d_data.size();
if (rec_starts.size() > 1) {
// Set first_row_len to the offset of the second row, if it exists
CUDA_TRY(cudaMemcpyAsync(&first_row_len,
Expand Down

0 comments on commit 36b3344

Please sign in to comment.