Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Empty columns is not returning empty dataframe in read_orc #11021

Closed
vuule opened this issue Jun 1, 2022 · 1 comment · Fixed by #11446
Closed

[BUG] Empty columns is not returning empty dataframe in read_orc #11021

vuule opened this issue Jun 1, 2022 · 1 comment · Fixed by #11446
Assignees
@vuule
Labels
bug Something isn't working cuIO cuIO issue
Projects
v22.10 Release

Comments

@vuule
Copy link
Contributor

vuule commented Jun 1, 2022

Same as #8668, only for ORC.
@vuule vuule added bug Something isn't working cuIO cuIO issue labels Jun 1, 2022
@vuule vuule added this to Issue-Needs prioritizing in v22.08 Release via automation Jun 1, 2022
@vuule vuule moved this from Issue-Needs prioritizing to Issue-P1 in v22.08 Release Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@vuule vuule removed this from Issue-P1 in v22.08 Release Aug 2, 2022
@vuule vuule added this to Issue-Needs prioritizing in v22.10 Release via automation Aug 2, 2022
@vuule vuule moved this from Issue-Needs prioritizing to Issue-P1 in v22.10 Release Aug 2, 2022
@vuule vuule mentioned this issue Aug 3, 2022
Merged
3 tasks
@vuule vuule self-assigned this Aug 3, 2022
v22.10 Release automation moved this from Issue-P1 to Done Aug 4, 2022
rapids-bot bot pushed a commit that referenced this issue Aug 4, 2022
@vuule
Return empty dataframe when reading an ORC file using empty columns…
9429099 
… option (#11446)

Changes are mostly equivalent to Parquet changes in #11018.

Store the `columns` option as `optional`:

- `nullopt` when columns are not passed by caller - read all columns.
- Empty vector when caller explicitly passes an empty list/vector - return empty dataframe.
- Vector of column names - read columns with given names.

Also includes a small cleanup of the code equivalent in the Parquet reader.

Fixes #11021

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - MithunR (https://github.com/mythrocks)
  - Nghia Truong (https://github.com/ttnghia)

URL: #11446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuule vuule

Labels
bug Something isn't working cuIO cuIO issue
Projects
No open projects
v22.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return empty dataframe when reading an ORC file using empty columns option vuule/cudf
1 participant
@vuule