-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return empty dataframe when reading an ORC file using empty columns
option
#11446
Return empty dataframe when reading an ORC file using empty columns
option
#11446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes LGTM, we will need the following workaround due to a bug in pandas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go from cython/python side! Thanks @vuule !!
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11446 +/- ##
===============================================
Coverage ? 86.47%
===============================================
Files ? 144
Lines ? 22856
Branches ? 0
===============================================
Hits ? 19765
Misses ? 3091
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the C++ and Java/JNI code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ approval.
@gpucibot merge |
Description
Changes are mostly equivalent to Parquet changes in #11018.
Store the
columns
option asoptional
:nullopt
when columns are not passed by caller - read all columns.Also includes a small cleanup of the code equivalent in the Parquet reader.
Fixes #11021
Checklist