Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove cudf.isclose. #13593

Open
bdice opened this issue Jun 20, 2023 · 0 comments
Open

Deprecate and remove cudf.isclose. #13593

bdice opened this issue Jun 20, 2023 · 0 comments
Labels
good first issue Good for newcomers Python Affects Python cuDF API.

Comments

@bdice
Copy link
Contributor

bdice commented Jun 20, 2023

Currently we have a function cudf.isclose that is undocumented. It mirrors cupy.isclose but also has null support. Pandas does not have a similar isclose function. After discussion with @shwina, @galipremsagar, and @vyasr we decided to deprecate and remove this function.

See also: #5105

As part of the deprecation, we decided to add a warning message indicating how to support nulls while using cupy.isclose.
@bdice bdice added deprecation Python Affects Python cuDF API. labels Jun 20, 2023
@vyasr vyasr mentioned this issue May 15, 2024
Closed
@vyasr vyasr added good first issue Good for newcomers and removed deprecation labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Python Affects Python cuDF API.
Projects
cuDF Python
Status: Todo
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vyasr @bdice