-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] use device_uvector instead of device_vector when possible #5380
Labels
Projects
Comments
vuule
added
libcudf
Affects libcudf (C++/CUDA) code.
Performance
Performance related issue
labels
Jun 4, 2020
Furthermore, |
Didn't see this when I wrote #7287. Going to close this as a duplicate since I provided a little more context in that issue. |
rapids-bot bot
pushed a commit
that referenced
this issue
Feb 4, 2021
#7256) Small PR to provide two fixes: - Use `rmm::device_uvector` in place of `device_vector` to improve efficiency. This is a scratch space, so supplied stream and default memory resource is used. Part of #5380 - Update `sort_helper::grouped_value` docstring to reflect change after use of stable sort. Authors: - Michael Wang (@isVoid) Approvers: - Vukasin Milovanovic (@vuule) - Ram (Ramakrishna Prabhu) (@rgsl888prabhu) - Mark Harris (@harrism) URL: #7256
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The new
device_uvector
does not initialize the allocated memory so it's much faster when the initial content is not relevant.There are many places where
device_vector
can be replaced withdevice_uvector
to improve the performance. Example:The text was updated successfully, but these errors were encountered: