Use uvector in replace_nulls; Fix sort_helper::grouped_value doc
#7256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
bug
vuule
reviewed
Jan 29, 2021
Co-authored-by: Vukasin Milovanovic <vukasin.milovanovic.87@gmail.com>
vuule
approved these changes
Jan 29, 2021
rgsl888prabhu
approved these changes
Jan 29, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7256 +/- ##
===============================================
+ Coverage 82.09% 82.18% +0.09%
===============================================
Files 97 100 +3
Lines 16474 16949 +475
===============================================
+ Hits 13524 13930 +406
- Misses 2950 3019 +69
Continue to review full report at Codecov.
|
harrism
requested changes
Feb 2, 2021
| @@ -99,7 +99,7 @@ struct sort_groupby_helper { | |||
| /** | |||
| * @brief Groups a column of values according to `keys` | |||
| * | |||
| * The order of values within each group is undefined. | |||
| * The values within each group maintain their original order. | |||
| @@ -387,7 +387,7 @@ std::unique_ptr<cudf::column> replace_nulls_policy_impl(cudf::column_view const& | |||
| auto valid_it = cudf::detail::make_validity_iterator(*device_in); | |||
| auto in_begin = thrust::make_zip_iterator(thrust::make_tuple(index, valid_it)); | |||
|
|
|||
| rmm::device_vector<cudf::size_type> gather_map(input.size()); | |||
| rmm::device_uvector<cudf::size_type> gather_map(input.size(), stream); | |||
There was a problem hiding this comment.
I think you should also update line 405 below (cudf::detail::gather call) to pass it the same stream.
harrism
added
0 - Waiting on Author
|
This PR was opened during burndown, so really it should target branch-0.19. In this case it's probably safe, but please be careful in the future. |
harrism
approved these changes
Feb 2, 2021
harrism
added
5 - Ready to Merge
|
rerun tests |
davidwendt
reviewed
Feb 3, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to provide two fixes:
rmm::device_uvectorin place ofdevice_vectorto improve efficiency. This is a scratch space, so supplied stream and default memory resource is used. Part of [BUG] use device_uvector instead of device_vector when possible #5380sort_helper::grouped_valuedocstring to reflect change after use of stable sort.