Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Update Cython bindings to catch C++ exceptions #862

Closed
jrhemstad opened this issue Feb 5, 2019 · 0 comments · Fixed by #1559
Closed

[FEA] Update Cython bindings to catch C++ exceptions #862

jrhemstad opened this issue Feb 5, 2019 · 0 comments · Fixed by #1559
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. proposal Change current process or code Python Affects Python cuDF API.

Comments

@jrhemstad
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The Cython bindings for libcudf should be updated to catch C++ exceptions and convert them to relevant Python exceptions where appropriate.

Describe the solution you'd like
Looking at the Cython documentation, it is straightforward to modify a Cython function to catch C++ exceptions.

It mainly entails adding except + to the Cython wrappers of libcudf functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. proposal Change current process or code Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants