Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strong index iterator docs. #10888

Merged
merged 3 commits into from
May 23, 2022
Merged

Add strong index iterator docs. #10888

merged 3 commits into from
May 23, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 18, 2022

This PR adds documentation for strongly-typed index iterators. Requested by @vyasr.

@bdice bdice added doc Documentation non-breaking Non-breaking change labels May 18, 2022
@bdice bdice requested a review from a team as a code owner May 18, 2022 19:21
@bdice bdice added this to PR-WIP in v22.06 Release via automation May 18, 2022
@bdice bdice requested a review from harrism May 18, 2022 19:21
@bdice bdice self-assigned this May 18, 2022
@bdice bdice requested a review from rgsl888prabhu May 18, 2022 19:21
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 18, 2022
@bdice bdice mentioned this pull request May 18, 2022
Merged
@bdice bdice requested a review from vyasr May 18, 2022 19:21
@bdice bdice changed the title Add strong typing iterator docs. Add strong index iterator docs. May 18, 2022
v22.06 Release automation moved this from PR-WIP to PR-Reviewer approved May 18, 2022
vyasr
vyasr approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good.

cpp/include/cudf/table/experimental/row_operators.cuh Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #10888 (4af331a) into branch-22.06 (6352b4e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 4af331a differs from pull request most recent head 0b81472. Consider uploading reports for the commit 0b81472 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10888      +/-   ##
================================================
+ Coverage         86.29%   86.33%   +0.03%     
================================================
  Files               144      144              
  Lines             22656    22665       +9     
================================================
+ Hits              19552    19567      +15     
+ Misses             3104     3098       -6
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 85.71% <ø> (ø)
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.79% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/index.py 92.06% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/core/series.py 95.17% <ø> (ø)
python/cudf/cudf/core/column/string.py 88.78% <100.00%> (+0.12%) ⬆️
python/dask_cudf/dask_cudf/groupby.py 97.42% <100.00%> (+<0.01%) ⬆️
python/dask_cudf/dask_cudf/tests/test_groupby.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.78% <0.00%> (+0.04%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b393a7...0b81472. Read the comment docs.

bdice and others added 2 commits May 18, 2022 22:51
@bdice @harrism
Remove hyphens.
643f5ab 
Co-authored-by: Mark Harris <mharris@nvidia.com>
@bdice
Mention lhs_iterator, rhs_iterator.
0b81472
@bdice bdice added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 21, 2022
@bdice
Copy link
Contributor Author

bdice commented May 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d1a0191 into rapidsai:branch-22.06 May 23, 2022
v22.06 Release automation moved this from PR-Reviewer approved to Done May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@vyasr vyasr vyasr approved these changes

@ttnghia ttnghia ttnghia approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@bdice bdice

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
v22.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bdice @harrism @vyasr @ttnghia