-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Upgrade to arrow-9.x
#11507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11507 +/- ##
===============================================
Coverage ? 86.48%
===============================================
Files ? 144
Lines ? 22850
Branches ? 0
===============================================
Hits ? 19761
Misses ? 3089
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arrow-9.0
arrow-9.x
ajschmidt8
approved these changes
Aug 10, 2022
galipremsagar
commented
Aug 10, 2022
bdice
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving CMake.
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
After upgrading to Arrow 9 (#11507), some systems experience a cmake issue: ``` cudf/cpp/build/_deps/arrow-src/cpp/CMakeLists.txt:864: error: The dependency target "xsimd" of target "arrow_dependencies" does not exist. ``` This may be due to the configurations for Arrow is looking for a local installation of `xsimd`, which does not exist or the installation path is not provided. This PRs adds an option to cudf cmake, specifying that Arrow should handle `xsimd` by itself. Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Bradley Dice (https://github.com/bdice) - Robert Maynard (https://github.com/robertmaynard) URL: #11513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
CMake
CMake build issue
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades
arrow
to9.x
incudf
.Checklist