Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary asserts in parquet tests #11544

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Removing unnecessary asserts in parquet tests #11544

merged 2 commits into from
Aug 16, 2022

Conversation

hyperbolic2346
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 commented Aug 16, 2022 •
edited
Loading

Description

As noticed in review of #11524 there are unnecessary asserts in the parquet tests. This removes those.

closes #11541

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@hyperbolic2346 hyperbolic2346 added 3 - Ready for Review Ready for review by team code quality cuIO cuIO issue non-breaking Non-breaking change labels Aug 16, 2022
@hyperbolic2346 hyperbolic2346 requested a review from a team as a code owner August 16, 2022 18:50
@hyperbolic2346 hyperbolic2346 self-assigned this Aug 16, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 16, 2022
@vuule vuule added the improvement Improvement / enhancement to an existing function label Aug 16, 2022
vuule
vuule approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov
Copy link

codecov bot commented Aug 16, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@4178a51). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 861d39d differs from pull request most recent head b1a9d41. Consider uploading reports for the commit b1a9d41 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.10   #11544   +/-   ##
===============================================
  Coverage                ?   86.36%           
===============================================
  Files                   ?      145           
  Lines                   ?    22949           
  Branches                ?        0           
===============================================
  Hits                    ?    19820           
  Misses                  ?     3129           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hyperbolic2346
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 65a7821 into rapidsai:branch-22.10 Aug 16, 2022
@hyperbolic2346 hyperbolic2346 deleted the mwilson/remove_parquet_assertions branch August 16, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@vuule vuule vuule approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@hyperbolic2346 hyperbolic2346

Labels
3 - Ready for Review Ready for review by team cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should remove column count assertions in parquet tests
3 participants
@hyperbolic2346 @ttnghia @vuule