Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should remove column count assertions in parquet tests #11541

Closed
hyperbolic2346 opened this issue Aug 16, 2022 · 1 comment · Fixed by #11544
Closed

Should remove column count assertions in parquet tests #11541

hyperbolic2346 opened this issue Aug 16, 2022 · 1 comment · Fixed by #11544

Comments

@hyperbolic2346
Copy link
Contributor

Vukasin pointed out that these asserts are testing table(previously)/table_view(now) constructor, rather then anything in Parquet. These should be removed.

Originally posted by @vuule in #11524 (comment)
@hyperbolic2346 hyperbolic2346 mentioned this issue Aug 16, 2022
Merged
3 tasks
@vuule
Copy link
Contributor

vuule commented Aug 16, 2022

Looked over other cuIO tests and could not find any other places where created tables are validated like this.

rapids-bot bot pushed a commit that referenced this issue Aug 16, 2022
@hyperbolic2346
Removing unnecessary asserts in parquet tests (#11544)
65a7821 
As noticed in review of #11524 there are unnecessary asserts in the parquet tests. This removes those.

closes #11541

Authors:
  - Mike Wilson (https://github.com/hyperbolic2346)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Nghia Truong (https://github.com/ttnghia)

URL: #11544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing unnecessary asserts in parquet tests hyperbolic2346/cudf
2 participants
@hyperbolic2346 @vuule