Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JNI for TableWithMeta to use schema_info instead of column_names #11566

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 18, 2022

Description

After #11364 TableWithMeta no longer returns the column names for a table since it is looking at the old column_names field instead of the newer schema_info field in the table metadata. This updates the JNI to use the schema_info to get the column names and adds a test for this API which was missing before.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jlowe jlowe added bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Aug 18, 2022
@jlowe jlowe self-assigned this Aug 18, 2022
@jlowe jlowe requested a review from a team as a code owner August 18, 2022 19:35
Copy link
Contributor

@rwlee rwlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there may be some other cases of this that were missed but this is all of the Java ones.

@jlowe
Copy link
Member Author

jlowe commented Aug 18, 2022

CI failure is unrelated, should be fixed by #11567

@ttnghia
Copy link
Contributor

ttnghia commented Aug 18, 2022

Rerun tests.

@ttnghia
Copy link
Contributor

ttnghia commented Aug 19, 2022

@gpucibot merge

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@288c81f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11566   +/-   ##
===============================================
  Coverage                ?   86.36%           
===============================================
  Files                   ?      145           
  Lines                   ?    22950           
  Branches                ?        0           
===============================================
  Hits                    ?    19820           
  Misses                  ?     3130           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rapids-bot rapids-bot bot merged commit 5ffee5c into rapidsai:branch-22.10 Aug 19, 2022
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants