Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct distribution data type in quantiles benchmark #11584

Merged

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Aug 23, 2022

Description

#11479 accidentally changed the distribution data type so the custom distribution was set for the wrong type.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working tests Unit testing for project non-breaking Non-breaking change labels Aug 23, 2022
@vuule vuule self-assigned this Aug 23, 2022
@vuule vuule requested a review from a team as a code owner August 23, 2022 18:56
@vuule vuule requested review from upsj and davidwendt August 23, 2022 18:56
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 23, 2022
@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@da6b3ed). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11584   +/-   ##
===============================================
  Coverage                ?   86.40%           
===============================================
  Files                   ?      145           
  Lines                   ?    22959           
  Branches                ?        0           
===============================================
  Hits                    ?    19838           
  Misses                  ?     3121           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vuule
Copy link
Contributor Author

vuule commented Aug 24, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8b9f203 into rapidsai:branch-22.10 Aug 24, 2022
@vuule vuule deleted the bug-quantiles-wrong-dist-type branch August 24, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants