-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force using old fmt in nvbench. #12064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we file an issue to track this so we don't forget?
Issue opened, #12065 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional improvement to the comment. Probably not worth waiting 2 hours of CI for that.
Yeah I'll leave it as whatever cmake-format was happy with. |
Codecov ReportBase: 87.51% // Head: 87.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #12064 +/- ##
=============================================
Coverage 87.51% 87.51%
=============================================
Files 133 133
Lines 21826 21826
=============================================
Hits 19100 19100
Misses 2726 2726 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a port of #12064 to 22.12 to unblock CI because forward mergers are currently disabled. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Robert Maynard (https://github.com/robertmaynard) URL: #12067
Force using old fmt in nvbench. (#12064)
This undoes #12064 and resolves #12065. Authors: - Vyas Ramasubramani (https://github.com/vyasr) - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice)
Description
The current version of nvbench is not compatible with the latest changes to fmt. This PR decouples us from needing to wait on upstreaming the compatibility changes to nvbench. These changes are necessary for building libcudf benchmarks until then.
Checklist