Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force using old fmt in nvbench. #12067

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Force using old fmt in nvbench. #12067

merged 1 commit into from
Nov 4, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 4, 2022

Description

This is a port of #12064 to 22.12 to unblock CI because forward mergers are currently disabled.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Nov 4, 2022
@vyasr vyasr self-assigned this Nov 4, 2022
@vyasr vyasr requested a review from a team as a code owner November 4, 2022 00:34
@github-actions github-actions bot added the CMake CMake build issue label Nov 4, 2022
@vyasr vyasr removed the libcudf Affects libcudf (C++/CUDA) code. label Nov 4, 2022
@ttnghia ttnghia mentioned this pull request Nov 4, 2022
Merged
3 tasks
@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Base: 87.47% // Head: 88.09% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (34dd028) compared to base (f817d96).
Patch has no changes to coverable lines.

❗ Current head 34dd028 differs from pull request most recent head 5078370. Consider uploading reports for the commit 5078370 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12   #12067      +/-   ##
================================================
+ Coverage         87.47%   88.09%   +0.61%     
================================================
  Files               133      135       +2     
  Lines             21826    21997     +171     
================================================
+ Hits              19093    19378     +285     
+ Misses             2733     2619     -114
Impacted Files Coverage Δ
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/cudf/cudf/io/parquet.py 90.45% <0.00%> (-0.39%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/cudf/cudf/core/dataframe.py 93.63% <0.00%> (-0.10%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.62% <0.00%> (-0.09%) ⬇️
python/cudf/cudf/io/orc.py 92.94% <0.00%> (-0.09%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wence- wence- mentioned this pull request Nov 4, 2022
Merged
3 tasks
@robertmaynard
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2a58ff6 into rapidsai:branch-22.12 Nov 4, 2022
@isVoid isVoid mentioned this pull request Nov 7, 2022
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Nov 7, 2022
@isVoid
Force using old fmt in nvbench. (#783)
aab7d86 
This is a port of rapidsai/cudf#12067. 

Original post:
> The current version of nvbench is not compatible with the latest changes to fmt. This PR decouples us from needing to wait on upstreaming the compatibility changes to nvbench. These changes are necessary for building libcudf benchmarks until then.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)

URL: #783
@vyasr vyasr deleted the hotfix/nvbench_fmt branch January 23, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @robertmaynard @galipremsagar