Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream parameter to List Manipulation and Operations APIs #14248

Merged

Conversation

SurajAralihalli
Copy link
Contributor

@SurajAralihalli SurajAralihalli commented Oct 4, 2023

Description

I have organized the public List APIs into three distinct categories based on their functionality, simplifying the PRs for easier and shorter reviews. This particular PR introduces the stream parameter only to the List Manipulation and Operations APIs, which fall under Section 1. See next comment for other sections.

  1. List Manipulation and Operations (combine.hpp, contains.hpp, count_elements.hpp)
concatenate_rows
concatenate_list_elements
contains_nulls
contains - search_keys
contains - search_key
index_of - search_keys
index_of - search_key
count_elements

This PR addresses issues in the following files:

  1. column_wrapper.hpp:

    • Corrects the improper passing of the stream value in the make_lists_column function.
    • Enables the missing cast to lists_column_view.
    • Substitutes copy_bitmask with cudf::detail::copy_bitmask to include the stream parameter.
  2. concatenate.cu:

    • Substitutes create_null_mask with cudf::detail::create_null_mask to include the stream parameter.

Reference 13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 4, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Oct 4, 2023
vyasr and others added 4 commits October 4, 2023 12:13
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@SurajAralihalli
Copy link
Contributor Author

SurajAralihalli commented Oct 5, 2023

  1. Sorting and Filtering (not included in this PR)
extract_list_element - index
extract_list_element - indices
segmented_gather
sequences - without steps
sequences - with steps
reverse
sort_lists
stable_sort_lists
apply_boolean_mask
distinct
  1. List Comparison and Intersection (not included in this PR)
have_overlap
intersect_distinct
union_distinct
difference_distinct

@SurajAralihalli SurajAralihalli marked this pull request as ready for review October 5, 2023 06:52
@SurajAralihalli SurajAralihalli requested a review from a team as a code owner October 5, 2023 06:52
@PointKernel PointKernel added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team labels Oct 5, 2023
@PointKernel
Copy link
Member

/ok to test

Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will approve once CI tests pass.

@SurajAralihalli Can you please update the PR description to include the bug fix info for concatenate and column_wrapper? Depending on how you see it, changes not included in this PR (e.g., sorting, filtering, etc.) can be deferred to a separate comment.

cpp/tests/streams/lists_test.cpp Outdated Show resolved Hide resolved
@PointKernel PointKernel changed the title add stream parameter to List Manipulation and Operations APIs Add stream parameter to List Manipulation and Operations APIs Oct 6, 2023
@PointKernel
Copy link
Member

/ok to test

@PointKernel
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e345620 into rapidsai:branch-23.12 Oct 9, 2023
60 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants