Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CUDA 12.2 #14712

Merged
merged 29 commits into from
Feb 10, 2024
Merged

Support CUDA 12.2 #14712

merged 29 commits into from
Feb 10, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 5, 2024

Description

  • switches to CUDA 12.2.2 for building conda packages and wheels
  • adds new tests running against CUDA 12.2.2

Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.

For more details see:

Planning a second round of PRs to revert these references back to a proper branch-24.{nn} release branch of shared-workflows once rapidsai/shared-workflows#166 is merged.

(created with rapids-reviser)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the conda label Jan 11, 2024
@jameslamb jameslamb changed the title use CUDA 12.2 for building and testing wheels WIP: add CUDA 12.2 support for conda packages and wheels Jan 11, 2024
@jameslamb jameslamb changed the title WIP: add CUDA 12.2 support for conda packages and wheels WIP: (DO NOT MERGE) add CUDA 12.2 support for conda packages and wheels Jan 11, 2024
@jameslamb
Copy link
Member Author

CUDA 12.2 builds and tests appear to be passing!

The test failures here look unrelated to this change.

ERROR benchmarks/API/bench_functions.py - ValueError: Cannot use `cases=AUTO` in file "bench_functions". `cases=AUTO` is only allowed in files whose name starts with "test_"
============ 468 passed, 9 warnings, 16 errors in 219.08s (0:03:39) ============

(build link)

I see similar failures on other recent pr builds at https://github.com/rapidsai/cudf/actions/workflows/pr.yaml.

@jameslamb jameslamb changed the title WIP: (DO NOT MERGE) add CUDA 12.2 support for conda packages and wheels (DO NOT MERGE) add CUDA 12.2 support for conda packages and wheels Jan 12, 2024
@jameslamb jameslamb marked this pull request as ready for review January 12, 2024 21:18
@jameslamb jameslamb requested a review from a team as a code owner January 12, 2024 21:18
@jakirkham jakirkham added feature request New feature or request non-breaking Non-breaking change 5 - DO NOT MERGE Hold off on merging; see PR for details labels Jan 13, 2024
@bdice
Copy link
Contributor

bdice commented Jan 16, 2024

#14756 will unblock the failing tests.

@jameslamb
Copy link
Member Author

thanks @bdice !

@jameslamb
Copy link
Member Author

A few tests are failing like this:

FAILED tests/test_groupby.py::test_groupby_basic[non_null-False-count] - TypeError: aggregate() got an unexpected keyword argument 'shuffle_method'
FAILED tests/test_groupby.py::test_groupby_basic[non_null-False-mean] - TypeError: aggregate() got an unexpected keyword argument 'shuffle_method'
FAILED tests/test_groupby.py::test_groupby_basic[non_null-False-std] - TypeError: aggregate() got an unexpected keyword argument 'shuffle_method'
...

(build link)

I suspect that'll be fixed by @rjzamora 's changes in #14762

@jameslamb jameslamb changed the title (DO NOT MERGE) add CUDA 12.2 support for conda packages and wheels Support CUDA 12.2 Jan 25, 2024
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Had a couple questions below

conda/recipes/cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/cudf/meta.yaml Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and I verified that the build and test jobs are running with the right CUDA packages (channel and version).

@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 9, 2024
@jakirkham
Copy link
Member

Toggling to start CI

@jakirkham jakirkham closed this Feb 9, 2024
@jakirkham jakirkham reopened this Feb 9, 2024
@bdice bdice requested a review from AyodeAwe February 9, 2024 22:06
@bdice
Copy link
Contributor

bdice commented Feb 10, 2024

/merge

@jakirkham
Copy link
Member

jakirkham commented Feb 10, 2024

Rerunning failed test. There was a network error during pip install (times 2)

@rapids-bot rapids-bot bot merged commit 630c885 into rapidsai:branch-24.04 Feb 10, 2024
69 checks passed
rapids-bot bot pushed a commit that referenced this pull request Feb 20, 2024
Follow-up to #14712

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #15069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants