-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CUDA 12.2 #14712
Support CUDA 12.2 #14712
Conversation
CUDA 12.2 builds and tests appear to be passing! The test failures here look unrelated to this change.
I see similar failures on other recent |
#14756 will unblock the failing tests. |
thanks @bdice ! |
A few tests are failing like this:
I suspect that'll be fixed by @rjzamora 's changes in #14762 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bradley! 🙏
Had a couple questions below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and I verified that the build and test jobs are running with the right CUDA packages (channel and version).
Toggling to start CI |
/merge |
Rerunning failed test. There was a network error during |
Follow-up to #14712 For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows` with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged. ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #15069
Description
Notes for Reviewers
This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.
For more details see:
dependencies.yaml
simplifications missed in refactor CUDA versions in dependencies.yaml #14733Planning a second round of PRs to revert these references back to a proper
branch-24.{nn}
release branch ofshared-workflows
once rapidsai/shared-workflows#166 is merged.(created with
rapids-reviser
)Checklist