-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor CUDA versions in dependencies.yaml #14733
refactor CUDA versions in dependencies.yaml #14733
Conversation
specific: | ||
- output_types: conda | ||
matrices: | ||
- matrix: | ||
cuda: "12.*" | ||
cuda: "11.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop 11.2 from this file? We still support 11.2 via CEC, but we don't need to be able to build envs with it any more do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps not really in scope for this PR. Something we can come back to later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are supporting it, wouldn't we want a way to construct an environment with this CUDA version for testing, debugging, etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11.2 has been dropped from our CI matrix and Docker images. I think it’s OK to remove this but I agree it’s probably better to keep the scope narrow here. At some point we will drop CUDA 11 entirely and clean up a lot of stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something we can come back to later.
I think it should come later, yeah.
I re-checked the diff and don't see anything that's obviously related to these warnings and errors. I just tried pushing an empty commit to re-trigger CI. If that doesn't work I'll ask for some help. |
These shouldn't timeout, I think. Do they run locally without problems? |
As noted offline by Bradley,
|
Just a note that the CI failure is not RAPIDS related. Issue is here: dask/distributed#8454 (cause is dask/distributed#8443) |
Thanks all! 🙏 |
* switches to CUDA 12.2.2 for building conda packages and wheels * adds new tests running against CUDA 12.2.2 ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 * rapidsai/shared-workflows#166 * adds some `dependencies.yaml` simplifications missed in #14733 Planning a second round of PRs to revert these references back to a proper `branch-24.{nn}` release branch of `shared-workflows` once rapidsai/shared-workflows#166 is merged. *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) - https://github.com/jakirkham Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Bradley Dice (https://github.com/bdice) - Jake Awe (https://github.com/AyodeAwe) URL: #14712
Description
Follow-up to #14644.
Contributes to rapidsai/build-planning#7.
Similar to rapidsai/rmm#1422, this proposes splitting the
cuda-version
dependency independencies.yaml
out to its own thing, separate from the bits of the CUDA Toolkitcudf
needs.Some other simplifications:
cuda-version
and CTK stuff was coupled){major}.{minor}
Checklist