Fix for logical and syntactical errors in libcudf c++ examples #15346

mhaseeb123 · 2024-03-20T03:22:15Z

Description

This PR fixes a couple of fatal compile and runtime errors in libcudf/strings examples

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

copy-pr-bot · 2024-03-20T03:22:18Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

ttnghia · 2024-03-20T06:41:09Z

/ok to test

davidwendt

Thanks for fixing this.

cpp/examples/strings/common.hpp

bdice

Do we need to add something to our CI to ensure these examples are run? They should be building already, as part of libcudf-example.

cudf/conda/recipes/libcudf/meta.yaml

Lines 153 to 155 in f9ac427

    
           - name: libcudf-example 
        
             version: {{ version }} 
        
             script: install_libcudf_example.sh

bdice

The CI logs of a recent build show that this was failing but not triggering a failure for the conda build.
https://github.com/rapidsai/cudf/actions/runs/8351275479/job/22859341825#step:7:4337

-- Build files have been written to: /opt/conda/conda-bld/work/cpp/examples/strings/build
[1/8] Building CUDA object CMakeFiles/custom_optimized.dir/custom_optimized.cu.o
FAILED: CMakeFiles/custom_optimized.dir/custom_optimized.cu.o 
/opt/conda/conda-bld/_build_env/bin/nvcc -forward-unknown-to-host-compiler -DFMT_HEADER_ONLY=1 -DLIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DSPDLOG_FMT_EXTERNAL -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_DISABLE_ABI_NAMESPACE -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -DTHRUST_IGNORE_ABI_NAMESPACE_ERROR -I/opt/conda/conda-bld/work/cpp/build/_deps/cccl-src/thrust/thrust/cmake/../.. -I/opt/conda/conda-bld/work/cpp/build/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include -I/opt/conda/conda-bld/work/cpp/build/_deps/cccl-src/cub/cub/cmake/../.. -isystem /opt/conda/conda-bld/work/cpp/build/_deps/dlpack-src/include -isystem /opt/conda/conda-bld/work/cpp/build/_deps/jitify-src -isystem /opt/conda/conda-bld/work/cpp/include -isystem /opt/conda/conda-bld/work/cpp/build/include -isystem /opt/conda/conda-bld/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -isystem /opt/conda/conda-bld/_build_env/targets/x86_64-linux/include "--generate-code=arch=compute_52,code=[compute_52,sm_52]" -Xcompiler=-fPIE --expt-extended-lambda --expt-relaxed-constexpr -MD -MT CMakeFiles/custom_optimized.dir/custom_optimized.cu.o -MF CMakeFiles/custom_optimized.dir/custom_optimized.cu.o.d -x cu -c /opt/conda/conda-bld/work/cpp/examples/strings/custom_optimized.cu -o CMakeFiles/custom_optimized.dir/custom_optimized.cu.o
/opt/conda/conda-bld/work/cpp/examples/strings/custom_optimized.cu(157): error: no instance of overloaded function "cudf::make_strings_column" matches the argument list
            argument types are: (cudf::size_type, rmm::device_uvector<cudf::size_type>, rmm::device_buffer, {...}, int)
    auto result = cudf::make_strings_column(names.size(), std::move(offsets), chars.release(), {}, 0);
                  ^

1 error detected in the compilation of "/opt/conda/conda-bld/work/cpp/examples/strings/custom_optimized.cu".

Yes. We need to add set -euo pipefail (aligning with our typical set of CI shell script flags) to cpp/examples/build.sh to ensure that compilation failures aren't allowed. Can we do that in this PR? Please push an error that would test it to make sure that compilation failures trigger CI failure.

mhaseeb123 · 2024-03-20T17:59:04Z

The CI logs of a recent build show that this was failing but not triggering a failure for the conda build. https://github.com/rapidsai/cudf/actions/runs/8351275479/job/22859341825#step:7:4337

-- Build files have been written to: /opt/conda/conda-bld/work/cpp/examples/strings/build
[1/8] Building CUDA object CMakeFiles/custom_optimized.dir/custom_optimized.cu.o
FAILED: CMakeFiles/custom_optimized.dir/custom_optimized.cu.o 
/opt/conda/conda-bld/_build_env/bin/nvcc -forward-unknown-to-host-compiler -DFMT_HEADER_ONLY=1 -DLIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DSPDLOG_FMT_EXTERNAL -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_DISABLE_ABI_NAMESPACE -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -DTHRUST_IGNORE_ABI_NAMESPACE_ERROR -I/opt/conda/conda-bld/work/cpp/build/_deps/cccl-src/thrust/thrust/cmake/../.. -I/opt/conda/conda-bld/work/cpp/build/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include -I/opt/conda/conda-bld/work/cpp/build/_deps/cccl-src/cub/cub/cmake/../.. -isystem /opt/conda/conda-bld/work/cpp/build/_deps/dlpack-src/include -isystem /opt/conda/conda-bld/work/cpp/build/_deps/jitify-src -isystem /opt/conda/conda-bld/work/cpp/include -isystem /opt/conda/conda-bld/work/cpp/build/include -isystem /opt/conda/conda-bld/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -isystem /opt/conda/conda-bld/_build_env/targets/x86_64-linux/include "--generate-code=arch=compute_52,code=[compute_52,sm_52]" -Xcompiler=-fPIE --expt-extended-lambda --expt-relaxed-constexpr -MD -MT CMakeFiles/custom_optimized.dir/custom_optimized.cu.o -MF CMakeFiles/custom_optimized.dir/custom_optimized.cu.o.d -x cu -c /opt/conda/conda-bld/work/cpp/examples/strings/custom_optimized.cu -o CMakeFiles/custom_optimized.dir/custom_optimized.cu.o
/opt/conda/conda-bld/work/cpp/examples/strings/custom_optimized.cu(157): error: no instance of overloaded function "cudf::make_strings_column" matches the argument list
            argument types are: (cudf::size_type, rmm::device_uvector<cudf::size_type>, rmm::device_buffer, {...}, int)
    auto result = cudf::make_strings_column(names.size(), std::move(offsets), chars.release(), {}, 0);
                  ^

1 error detected in the compilation of "/opt/conda/conda-bld/work/cpp/examples/strings/custom_optimized.cu".

Yes. We need to add set -euo pipefail (aligning with our typical set of CI shell script flags) to cpp/examples/build.sh to ensure that compilation failures aren't allowed. Can we do that in this PR? Please push an error that would test it to make sure that compilation failures trigger CI failure.

Sounds good, @bdice. Pushing in an error to test the CI in a commit now.

bdice · 2024-03-20T19:44:22Z

/ok to test

mhaseeb123 · 2024-03-20T21:03:48Z

/ok to test

Including strings_column_view header to fix build error

harrism

Just one small suggestion.

cpp/examples/basic/src/process_csv.cpp

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

cpp/examples/basic/src/process_csv.cpp

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

mhaseeb123 · 2024-04-08T22:32:42Z

/ok to test

mhaseeb123 · 2024-04-08T23:31:59Z

/ok to test

mhaseeb123 · 2024-04-09T01:46:25Z

@bdice looks like the CI is now failing at the #error https://github.com/rapidsai/cudf/actions/runs/8607963757/job/23589503980?pr=15346#step:7:4992. Going to remove that line and re-trigger CI

mhaseeb123 · 2024-04-09T01:54:28Z

/ok to test

mhaseeb123 · 2024-04-09T18:16:33Z

/ok to test

mhaseeb123 · 2024-04-10T00:50:22Z

/merge

fix for libcudf examples

a778a8d

mhaseeb123 requested a review from a team as a code owner March 20, 2024 03:22

mhaseeb123 requested review from harrism and nvdbaranec March 20, 2024 03:22

github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 20, 2024

mhaseeb123 added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change Reliability bug Something isn't working and removed Reliability labels Mar 20, 2024

ttnghia approved these changes Mar 20, 2024

View reviewed changes

davidwendt requested changes Mar 20, 2024

View reviewed changes

cpp/examples/strings/common.hpp Outdated Show resolved Hide resolved

bdice reviewed Mar 20, 2024

View reviewed changes

bdice requested changes Mar 20, 2024

View reviewed changes

mhaseeb123 and others added 2 commits March 20, 2024 18:03

suggested changes from PR review

183dad4

Merge branch 'branch-24.06' into cudf-examples-udpate

ba524f3

adding pipefail to build.sh

cb93eec

mhaseeb123 changed the title ~~fix for libcudf examples~~ Fix for logical and syntactical errors in libcudf c++ examples Mar 22, 2024

Including strings_column_view header

68edc7a

Including strings_column_view header to fix build error

harrism requested changes Apr 2, 2024

View reviewed changes

cpp/examples/basic/src/process_csv.cpp Outdated Show resolved Hide resolved

Update cpp/examples/basic/src/process_csv.cpp

73a4e0a

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

harrism reviewed Apr 4, 2024

View reviewed changes

cpp/examples/basic/src/process_csv.cpp Outdated Show resolved Hide resolved

harrism approved these changes Apr 4, 2024

View reviewed changes

mhaseeb123 and others added 2 commits April 8, 2024 11:55

Update cpp/examples/basic/src/process_csv.cpp

96a7d8a

Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>

minor clang-format fix

323e460

mhaseeb123 added 2 commits April 8, 2024 12:07

Merge branch 'branch-24.06' into cudf-examples-udpate

33acd7c

Merge branch 'branch-24.06' into cudf-examples-udpate

5534aa5

minor copyright fix

2acdf31

removing the CI #error

dfd9be4

Merge branch 'branch-24.06' into cudf-examples-udpate

fd78274

davidwendt approved these changes Apr 9, 2024

View reviewed changes

bdice approved these changes Apr 9, 2024

View reviewed changes

rapids-bot bot merged commit 15c148d into rapidsai:branch-24.06 Apr 10, 2024
70 checks passed

mhaseeb123 deleted the cudf-examples-udpate branch April 10, 2024 00:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for logical and syntactical errors in libcudf c++ examples #15346

Fix for logical and syntactical errors in libcudf c++ examples #15346

mhaseeb123 commented Mar 20, 2024 •

edited

Loading

copy-pr-bot bot commented Mar 20, 2024

ttnghia commented Mar 20, 2024

davidwendt left a comment

bdice left a comment

bdice left a comment •

edited

Loading

mhaseeb123 commented Mar 20, 2024

bdice commented Mar 20, 2024

mhaseeb123 commented Mar 20, 2024

harrism left a comment

mhaseeb123 commented Apr 8, 2024

mhaseeb123 commented Apr 8, 2024

mhaseeb123 commented Apr 9, 2024

mhaseeb123 commented Apr 9, 2024

mhaseeb123 commented Apr 9, 2024

mhaseeb123 commented Apr 10, 2024

	- name: libcudf-example
	version: {{ version }}
	script: install_libcudf_example.sh

Fix for logical and syntactical errors in libcudf c++ examples #15346

Fix for logical and syntactical errors in libcudf c++ examples #15346

Conversation

mhaseeb123 commented Mar 20, 2024 • edited Loading

Description

Checklist

copy-pr-bot bot commented Mar 20, 2024

ttnghia commented Mar 20, 2024

davidwendt left a comment

Choose a reason for hiding this comment

bdice left a comment

Choose a reason for hiding this comment

bdice left a comment • edited Loading

Choose a reason for hiding this comment

mhaseeb123 commented Mar 20, 2024

bdice commented Mar 20, 2024

mhaseeb123 commented Mar 20, 2024

harrism left a comment

Choose a reason for hiding this comment

mhaseeb123 commented Apr 8, 2024

mhaseeb123 commented Apr 8, 2024

mhaseeb123 commented Apr 9, 2024

mhaseeb123 commented Apr 9, 2024

mhaseeb123 commented Apr 9, 2024

mhaseeb123 commented Apr 10, 2024

mhaseeb123 commented Mar 20, 2024 •

edited

Loading

bdice left a comment •

edited

Loading