Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NaN handling in drop_list_duplicates #7662

Merged
merged 38 commits into from
Mar 31, 2021
Merged

Fix NaN handling in drop_list_duplicates #7662

merged 38 commits into from
Mar 31, 2021

Commits on Mar 17, 2021

  1. Add tests for drop_list_duplicates in case of input containing floati… 

    …ng point numbers with NaN
    @ttnghia
    ttnghia committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    81e0d79 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Add negative NaN into the tests

    @ttnghia
    ttnghia committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    e431549 View commit details
    Browse the repository at this point in the history

  2. Rewrite tests: split tests into smaller tests with some improvements

    @ttnghia
    ttnghia committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    84b06a3 View commit details
    Browse the repository at this point in the history

  3. Some improvement to floating point tests with NaNs

    @ttnghia
    ttnghia committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    34305f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Add customized comparators for drop_list_duplicates, still need to up… 

    …date doc
    @ttnghia
    ttnghia committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    fa46446 View commit details
    Browse the repository at this point in the history

  2. Some cleanup

    @ttnghia
    ttnghia committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    452835b View commit details
    Browse the repository at this point in the history

  3. Rewrite doc for element_comparator and element_comparator_fn

    @ttnghia
    ttnghia committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    42535a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Using type_dispatcher only for host code

    @ttnghia
    ttnghia committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    2b5b8e4 View commit details
    Browse the repository at this point in the history

  2. Fix memory access violation bug when using reference to column_device… 

    …_view
    @ttnghia
    ttnghia committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    dfa1c8a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/branch-0.19' into fix_nan_drop_l… 

    …ist_duplicates
    @ttnghia
    ttnghia committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    f2c4d5d View commit details
    Browse the repository at this point in the history

  4. Add test case when the list contains both -0.0 and 0.0

    @ttnghia
    ttnghia committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    9d07cc7 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Rename constants

    @ttnghia
    ttnghia committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    ef6d7e2 View commit details
    Browse the repository at this point in the history

  2. Change has_null from template parameter to runtime parameter

    @ttnghia
    ttnghia committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    725155b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-0.19' into fix_nan_drop_list_duplicates

    @ttnghia
    ttnghia committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    97815de View commit details
    Browse the repository at this point in the history

  4. Remove redundant qualifiers from class constructor

    @ttnghia
    ttnghia committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    6f76f8e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. AddAdd nan_equality enum to specify whether NaN elements should be … 

    …considered as equal or not
    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    c66b88f View commit details
    Browse the repository at this point in the history

  2. Rewrite drop_list_duplicate, adding nans_equal parameter, allowin… 

    …g to specify whether to handle NaNs as the same value or different values
    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    806b900 View commit details
    Browse the repository at this point in the history

  3. Rewrite tests for drop_list_duplicates

    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    d96bc79 View commit details
    Browse the repository at this point in the history

  4. Rewrite collect_set_aggregation, adding nans_equal parameter

    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    0246c78 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    2185d8a View commit details
    Browse the repository at this point in the history

  6. Change nan_equality enum names

    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    919e859 View commit details
    Browse the repository at this point in the history

  7. Fix enum in unit tests for drop_list_duplicates

    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    a002e62 View commit details
    Browse the repository at this point in the history

  8. Add an option to specify NaNs are compared equal only if they have th… 

    …e same sign
    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    26cae09 View commit details
    Browse the repository at this point in the history

  9. Rework drop_list_duplicates for the new nan_equality option

    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    4356bf6 View commit details
    Browse the repository at this point in the history

  10. Rewrite unit tests for drop_list_duplicates that can test for all c… 

    …ases of `nan_equality`
    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    e4cfa11 View commit details
    Browse the repository at this point in the history

  11. Revert "Rewrite unit tests for drop_list_duplicates that can test f… 

    …or all cases of `nan_equality`"

This reverts commit e4cfa11.
    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    98ec9b1 View commit details
    Browse the repository at this point in the history

  12. Revert "Rework drop_list_duplicates for the new nan_equality option" 

    This reverts commit 4356bf6.
    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    7a9f850 View commit details
    Browse the repository at this point in the history

  13. Revert "Add an option to specify NaNs are compared equal only if they… 

    … have the same sign"

This reverts commit 26cae09.
    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    04b120d View commit details
    Browse the repository at this point in the history

  14. Fix typo

    @ttnghia
    ttnghia committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    0973be9 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Avoid initialize-then-assign

    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    fa035a6 View commit details
    Browse the repository at this point in the history

  2. Replace thrust::any_of by thrust::count_if

    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8520f0d View commit details
    Browse the repository at this point in the history

  3. Copy column by constructor

    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    49bfe13 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/branch-0.19' into fix_nan_drop_l… 

    …ist_duplicates

# Conflicts:
#	cpp/src/lists/drop_list_duplicates.cu
    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    3d50d8e View commit details
    Browse the repository at this point in the history

  5. Minor cleanup

    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    27b5beb View commit details
    Browse the repository at this point in the history

  6. Replace is_null by is_null_nocheck

    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    1406a25 View commit details
    Browse the repository at this point in the history

  7. Replace make_numeric_column by device_uvector

    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    32b4393 View commit details
    Browse the repository at this point in the history

  8. Rewrite comments, and add a condition check for nans_equal == ALL_EQU… 

    …AL before calling to `has_negative_nans`
    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    b5af91e View commit details
    Browse the repository at this point in the history

  9. Merge branch 'branch-0.19' into fix_nan_drop_list_duplicates

    @ttnghia
    ttnghia committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    7812e05 View commit details
    Browse the repository at this point in the history