Java bindings for approx_percentile #9094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e their usage when calling the groupby object.
… in python bindings.
…pe-dispatch on the plain tdigest aggregation.
Signed-off-by: Andy Grove <andygrove@nvidia.com>
github-actions
bot
added
CMake
8 tasks
…zes (still need to add code to ignore them during cluster building). Use groupby group_labels to avoid use of lower_bound() during reduction of values.
revans2
reviewed
Aug 26, 2021
revans2
approved these changes
Aug 27, 2021
| * a t-digest aggregation. | ||
| * | ||
| * @param percentiles Required percentiles [0,1] | ||
| * @return the percentiles as doubles, in the same order passed in |
There was a problem hiding this comment.
nit: Is the output type a list of doubles or what?
| * a t-digest aggregation. | ||
| * | ||
| * @param percentiles Column containing percentiles [0,1] | ||
| * @return the percentiles as doubles, in the same order passed in |
There was a problem hiding this comment.
nit: what is the output type?
…roupby in lieu of lower_bound checks during merge aggregation. Proper handling of null input values for regular tdigest aggregation.
…digests. Return null lists when calling percentile_approx on empty tdigests.
…check that I accidentally deleted.
…some internal constants and functions together; removed the ability to specify an output type from percentile_approx.
… tdigest aggregations. Change 'delta' to 'max_centroids' in externally facing interfaces to tdigest aggregations.
github-actions
bot
removed
CMake
andygrove
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9094 +/- ##
================================================
- Coverage 10.85% 10.80% -0.06%
================================================
Files 115 116 +1
Lines 19158 19321 +163
================================================
+ Hits 2080 2087 +7
- Misses 17078 17234 +156
Continue to review full report at Codecov.
|
revans2
approved these changes
Sep 24, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #8983 and adds Java bindings.