Use CTAD with Thrust function objects #9768
Conversation
codereport
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9768 +/- ##
================================================
- Coverage 10.49% 10.47% -0.02%
================================================
Files 119 119
Lines 20305 20368 +63
================================================
+ Hits 2130 2133 +3
- Misses 18175 18235 +60
Continue to review full report at Codecov.
|
codereport
added
3 - Ready for Review
| @@ -315,7 +315,7 @@ std::unique_ptr<cudf::column> gather( | |||
| d_out_offsets + output_count, | |||
| [] __device__(auto size) { return static_cast<size_t>(size); }, | |||
| size_t{0}, | |||
| thrust::plus<size_t>{}); | |||
| thrust::plus{}); | |||
There was a problem hiding this comment.
This is surprising to me.
How does it deduce the type without any parameters?
There was a problem hiding this comment.
Me too. Does it somehow use the other arguments to xform_reduce?
There was a problem hiding this comment.
The return type is dictated by the type of the initial value, aka size_t{0} on the line above.
codereport
added
5 - Ready to Merge
|
@gpucibot merge |
While reviewing another PR, I noticed unnecessary usage of explicit template parameters with Thrust function objects and decided to open a small PR to clean this up (CTAD showed up in C++17).
CI depends on #9766