Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] cuML to expose a "proper" C-API #77

Closed
teju85 opened this issue Jan 11, 2019 · 5 comments
Closed

[FEA] cuML to expose a "proper" C-API #77

teju85 opened this issue Jan 11, 2019 · 5 comments
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request

Comments

@teju85
Copy link
Member

teju85 commented Jan 11, 2019

Is your feature request related to a problem? Please describe.
Currently, we directly expose underlying C++ implementations via cython. Since cython can also understand C++ interfaces, all is well for us. But if we need wider adoption, I think we should expose a true C-API (for eg: declaring symbols under "extern C"). Such an interface can then be easily usable across multiple languages.

Describe the solution you'd like
As a first step, we could just start by wrapping our *_c.h files under each algo folder of cuML with "extern C" declarations.

Describe alternatives you've considered
-NA-

Additional context
None.

@teju85 teju85 added ? - Needs Triage Need team to review and classify feature request New feature or request labels Jan 11, 2019
@dantegd
Copy link
Member

dantegd commented Jan 12, 2019

Given that we are doing that *_.c.h approach for all current (and immediately imminent) algorithms, what would you say would be the ideal long term solution beyond wrapping them in extern declarations?

Also tagging @datametrician

@datametrician
Copy link

I think the only long term solution is wrapping them in *_c.h, and we would welcome anyone to do that. That said, given our current workload, this isn't a priority instead of getting more algorithms out with a C++ API and python bindings.

If any user who needs a C API would like to do this for RAPIDS I would be very happy.

@datametrician datametrician added 0 - Backlog In queue waiting for assignment and removed ? - Needs Triage Need team to review and classify labels Jan 12, 2019
@teju85
Copy link
Member Author

teju85 commented Jan 14, 2019

My main aim for filing this issue was to make sure that over the course of things, we will be able to support other languages wrapping around the core of cuML. I wasn't also requesting for prioritizing this one. But making sure that this doesn't slip through the cracks.

Apart from 'extern', I can't think of other things, right now. I'll update this issue, if I remember anything else.

@teju85
Copy link
Member Author

teju85 commented Feb 27, 2019

Issue #248 briefly discusses the C-API. I believe once we have a proper native C++ API. We should only then try to plan for and implement this.

@datametrician
Copy link

I agree, let's close this in favor of #248. I think this is lower priority than a native C++ API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants