Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python API for pairwise_polygon_distance #1074

Merged
merged 24 commits into from
May 3, 2023
Merged

Python API for pairwise_polygon_distance #1074

merged 24 commits into from
May 3, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 13, 2023

Description

This PR adds python API for pairwise_polygon_distance

depends on #1073

closes #1054

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Apr 13, 2023
@isVoid isVoid self-assigned this Apr 14, 2023
@isVoid isVoid mentioned this pull request Apr 14, 2023
Closed
@isVoid isVoid marked this pull request as ready for review May 2, 2023 16:51
@isVoid isVoid requested a review from a team as a code owner May 2, 2023 16:51
@isVoid isVoid requested review from trxcllnt and harrism May 2, 2023 16:51
@isVoid isVoid added the feature request New feature or request label May 2, 2023
@isVoid isVoid requested review from thomcom and removed request for trxcllnt May 2, 2023 16:51
@isVoid isVoid added the non-breaking Non-breaking change label May 2, 2023
harrism
harrism approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, just some doc improvements.

python/cuspatial/cuspatial/core/spatial/distance.py Outdated Show resolved Hide resolved
python/cuspatial/cuspatial/core/spatial/distance.py Outdated Show resolved Hide resolved
@isVoid
Copy link
Contributor Author

isVoid commented May 3, 2023

/merge

@rapids-bot rapids-bot bot merged commit 986c1a6 into rapidsai:branch-23.06 May 3, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

Assignees

@isVoid isVoid

Labels
cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python API Polygon-Polygon Distance
3 participants
@isVoid @thomcom @harrism