Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column API for pairwise_polygon_distance #1073

Merged
merged 17 commits into from
May 2, 2023
Merged

Column API for pairwise_polygon_distance #1073

merged 17 commits into from
May 2, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 13, 2023 •
edited
Loading

Description

This PR adds column API for pairwise_polygon_distance.

This PR also adds CUSPATIAL_HOST_DEVICE_EXPECTS macro to help error assertion in __host__ __device__ functions.

closes #1053

depends on #1065

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested review from a team as code owners April 13, 2023 18:02
@isVoid isVoid requested review from harrism and trxcllnt April 13, 2023 18:02
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Apr 13, 2023
@isVoid isVoid added feature request New feature or request bug Something isn't working non-breaking Non-breaking change and removed bug Something isn't working labels Apr 13, 2023
@isVoid isVoid marked this pull request as draft April 13, 2023 18:05
@isVoid isVoid mentioned this pull request Apr 13, 2023
Merged
3 tasks
@isVoid isVoid self-assigned this Apr 14, 2023
@isVoid isVoid marked this pull request as ready for review April 26, 2023 18:30
@isVoid isVoid requested a review from thomcom April 26, 2023 21:14
harrism
harrism approved these changes Apr 26, 2023
View reviewed changes
cpp/include/cuspatial/assert.cuh Show resolved Hide resolved
@isVoid
Copy link
Contributor Author

isVoid commented May 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit 2d02073 into rapidsai:branch-23.06 May 2, 2023
rapids-bot bot pushed a commit that referenced this pull request May 3, 2023
@isVoid
Python API for pairwise_polygon_distance (#1074)
986c1a6 
This PR adds python API for `pairwise_polygon_distance`

depends on #1073 

closes #1054

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)

URL: #1074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@isVoid isVoid

Labels
cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column API Polygon-Polygon Distance
3 participants
@isVoid @thomcom @harrism