-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve point_in_polygon documentation regarding poly_ring_offsets #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the same polygons.
Should probably also fix the taxi notebook but I need to get it running locally before I can test any fixes. |
harrism
commented
Mar 29, 2022
harrism
commented
Mar 29, 2022
cwharris
approved these changes
Mar 29, 2022
thomcom
approved these changes
Mar 29, 2022
Might be out of scope, would it be helpful to add an example of input to help demonstrate the use of the API? |
@isVoid Yes. However I'm going to merge this and add your note to the still-open issue. This way at least we get some improvement in the current release. |
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Documentation
libcuspatial
Relates to the cuSpatial C++ library
non-breaking
Non-breaking change
Python
Related to Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #492.
Adds notes to the Python and C++ documentation explaining that behavior is undefined if there are rings in
poly_ring_offsets
that are not referenced bypoly_offsets