-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documentation with Pydata Sphinx Theme, and more #523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the docs and updating to the new format @isVoid ! I have some edit suggestions for the docs while you are at it.
cuSpatial proposes a new GeoArrow format from the fruit of discussions | ||
with the GeoPandas team. GeoArrow is a packed columnar data format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GeoArrow exists independently of cuSpatial. This makes it sound like we invented GeoArrow. I don't think this sentence belongs in our documentation. (CC @thomcom )
cuSpatial proposes a new GeoArrow format from the fruit of discussions | |
with the GeoPandas team. GeoArrow is a packed columnar data format | |
GeoArrow is a packed columnar data format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. I had the first implementation, though GeoArrow diverged from my implementation a little as per the previous discussions. :D :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
Co-authored-by: Mark Harris <mharris@nvidia.com>
Thanks to @ajschmidt8 , the documentation is now live for review at https://627d5be4c229560ba620c84d--docs-rapids-ai.netlify.app/api/cuspatial/nightly/ ! |
@thomcom could you please review this PR? |
"mlines": | ||
[1, 3] | ||
}) | ||
|
||
Which encodes a GeoPandas Series:: | ||
|
||
series = geopandas.Series([ | ||
LineString((0, 0), (0, 1), (0, 2)), | ||
MultiLineString([(1, 0), (1, 1), (1, 2)], | ||
[(2, 0), (2, 1), (2, 2)], | ||
) | ||
LineString((3, 0), (3, 1), (3, 2)), | ||
LineString((4, 0), (4, 1), (4, 2)), | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, sorry for not being in this convo earlier. I'll be looking into dropping the 'bounding regions' in the mlines
object to fit GeoArrow format correctly.
@gpucibot merge |
This PR closes #459 . It updates the sphinx theme with
Pydata-sphinx-theme
.Besides this PR also:
internals.rst
to focus on discussing GeoArrow format. Shuffled around the docstrings forGeoArrowBuffer
and make background description and API usage relatively independent, but all presented in the same page for shared context.from_geopandas
docstring.