Introduce multipoint_range interface; Refactors point_distance API to support multipoint to multipoint distance.
#731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
feature request
…into feature/multipoint_array
isVoid
changed the title
Multipoint_array interface; Refactors point_distance API to support multipoint to multipoint distance.multipoint_array interface; Refactors point_distance API to support multipoint to multipoint distance.
isVoid
added
3 - Ready for Review
isVoid
requested review from
thomcom and
harrism
and removed request for
zhangjianting and
jrhemstad
3 tasks
thomcom
approved these changes
Oct 7, 2022
cpp/include/cuspatial/experimental/array_view/multipoint_array.cuh
Outdated
Show resolved
Hide resolved
Co-authored-by: H. Thomson Comer <thomcom@gmail.com>
…l into feature/multipoint_array
harrism
requested changes
Oct 11, 2022
Comment on lines
35
to
38
| std::optional<cudf::device_span<cudf::size_type const>> multipoints1_offset, | ||
| cudf::column_view const& points1_xy, | ||
| std::optional<cudf::device_span<cudf::size_type const>> multipoints2_offset, | ||
| cudf::column_view const& points2_xy, |
There was a problem hiding this comment.
I think it would be clearer to have the point columns before their optional multipoint offset parameters.
Suggested change
| std::optional<cudf::device_span<cudf::size_type const>> multipoints1_offset, | |
| cudf::column_view const& points1_xy, | |
| std::optional<cudf::device_span<cudf::size_type const>> multipoints2_offset, | |
| cudf::column_view const& points2_xy, | |
| cudf::column_view const& points1_xy, | |
| std::optional<cudf::device_span<cudf::size_type const>> multipoints1_offset, | |
| cudf::column_view const& points2_xy, | |
| std::optional<cudf::device_span<cudf::size_type const>> multipoints2_offset, |
There was a problem hiding this comment.
Seems reasonable to me as well.
Should we update https://github.com/rapidsai/cuspatial/blob/branch-22.12/cpp/include/cuspatial/distance/point_linestring_distance.hpp and https://github.com/rapidsai/cuspatial/blob/branch-22.12/cpp/include/cuspatial/point_linestring_nearest_points.hpp too?
There was a problem hiding this comment.
oh, I didn't realize there are multiple APIs that follow this style. I would say leave it alone then.
There was a problem hiding this comment.
Oops, I forgot to revert this suggestion before I merge. Will address in #734
cpp/include/cuspatial/experimental/array_view/multipoint_array.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/array_view/multipoint_array.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/array_view/multipoint_array.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/array_view/multipoint_array.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/array_view/multipoint_array.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/geometry_collection/multipoint.cuh
Outdated
Show resolved
Hide resolved
isVoid
changed the title
multipoint_array interface; Refactors point_distance API to support multipoint to multipoint distance.multipoint_range interface; Refactors point_distance API to support multipoint to multipoint distance.
harrism
approved these changes
Oct 18, 2022
|
@gpucibot merge |
isVoid
added a commit
to isVoid/cuspatial
that referenced
this pull request
Oct 19, 2022
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
This PR adds python bindings to Point-point distance. Depend on #731 Reverts change to comment: #731 (comment) Close #578 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: #734
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
…ing distance API (#747) Follow up to #731 , this PR introduces a new range object named `multilinestring_range` and simplifies the point-linestring distance API. Closes #705 . Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: #747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #704
Contributes to #703
This PR introduces
Multipoint_rangeinterface, and simplifies the API ofpoint_distance. Also updates thepoint_distanceto support multipoint-multipoint distance.Checklist