Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce
multipoint_range
interface; Refactorspoint_distance
API to support multipoint to multipoint distance. #731Introduce
multipoint_range
interface; Refactorspoint_distance
API to support multipoint to multipoint distance. #731Changes from 11 commits
0ec7c51
ac6083a
8cb91d8
fc0495d
ef86d38
535abe1
12d6681
599bb7c
cdcbcac
3101fba
c559e9a
016af08
5235d23
7a49708
854c76c
7db2435
a791dd4
2746196
cd15dc4
fcf5e15
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be clearer to have the point columns before their optional multipoint offset parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me as well.
Should we update https://github.com/rapidsai/cuspatial/blob/branch-22.12/cpp/include/cuspatial/distance/point_linestring_distance.hpp and https://github.com/rapidsai/cuspatial/blob/branch-22.12/cpp/include/cuspatial/point_linestring_nearest_points.hpp too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I didn't realize there are multiple APIs that follow this style. I would say leave it alone then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I forgot to revert this suggestion before I merge. Will address in #734