Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multilinestring in Linestring Distance #753

Closed

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 26, 2022

Description

This PR adds support to multilinestring support to LineString Distance API. And in turn refactors header-only API, column API, and python API.

This PR introduces a few new non-owning objects for geometry and geometry collections: linestring_ref, multilinestring_ref, which greatly simplifies the implementation of the linestring distance kernel.

Depends on #752 and #747

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

isVoid and others added 30 commits October 4, 2022 16:50
Co-authored-by: H. Thomson Comer <thomcom@gmail.com>
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Oct 26, 2022
rapids-bot bot pushed a commit that referenced this pull request Nov 7, 2022
…nge`, adds support to multilinestring distance (#755)

Note, this is the first part of `pairwise_linestring_distance` refactoring, part 1 of PR: #753

Depends on #752 

Contributes to #706, #703

Closes #745

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)

URL: #755
isVoid added a commit to isVoid/cuspatial that referenced this pull request Nov 8, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Nov 8, 2022

Superceded by #755 and #786

@isVoid isVoid closed this Nov 8, 2022
rapids-bot bot pushed a commit that referenced this pull request Nov 15, 2022
…wise_linestring_distance` (#786)

This is a port of the second half of #753, closes #706

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: #786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant