Fix OB bug in linestring_intersection_intermediates.remove_if Function
#945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
bug
isVoid
changed the title
linestring_intersection_intermediates.remove_if function.linestring_intersection_intermediates.remove_if Function
harrism
requested changes
Feb 22, 2023
cpp/include/cuspatial/experimental/detail/find/find_and_combine_segment.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/find/find_duplicate_points.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/linestring_intersection_count.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/linestring_intersection_with_duplicates.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/linestring_intersection_with_duplicates.cuh
Outdated
Show resolved
Hide resolved
…into bug/remove_if_ob
harrism
approved these changes
Feb 27, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug mentioned by @thomcom at #862 (review). When computing the lookup id for each group to find the number of geometry removed in previous groups, the previous computation is flawed and resulted in OB access.
Besides, this PR also adds
CUDA_TRY(cudaGetLastError())in several kernel calls in the intersection code path.This PR also refined the documentation for
remove_ifand related helper function.Checklist