Disable librmm and libcudf docs #464
Conversation
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Can't add suggestions since the code wasn't modified, but I think we should add a note in Probably would do it as a newline after the library descriptions. |
|
@jarmak-nv does this change look like what you were intending? I didn't include a newline because I wasn't sure if that would work. |
There was a problem hiding this comment.
Approving, but would like to see similar changes in RMM/cuDF's doc intro text as well (and similar comment about testing the linebreak if you have time).
RMM:
RAPIDS Memory Manager (RMM) is a central place for all device memory allocations in cuDF (C++ and Python) and other RAPIDS libraries. In addition, it is a replacement allocator for CUDA Device Memory (and CUDA Managed Memory) and a pool allocator to make CUDA device memory allocation / deallocation faster and asynchronous. As of 23.12 we have integrated librmm's docs alongside RMM's docs for a unified experience.
cuDF:
cuDF is a Python GPU DataFrame library (built on the Apache Arrow columnar memory format) for loading, joining, aggregating, filtering, and otherwise manipulating data. As of 24.02 we have integrated libcudf's docs alongside cuDF's docs for a unified experience.
|
😞 |
|
Worth a shot! @jarmak-nv feel free to merge whenever you approve. I can make the changes to cudf/rmm separately. |
|
👍 Will do once rapidsai/cudf#13846 goes in |
|
We're no longer planning to remove the cudf doxygen docs in rapidsai/cudf#13846. We want to spend a bit more time iterating on them until everyone is happy with their appearance. I'll reopen this PR from draft once more of those changes are completed and I'll update this PR at that time based on the timeline. |
|
The rmm piece is done in #478. I'm going to close this PR for now. I can reopen it for cudf if and when we're ready to make the change for just cudf. |
These doxygen doc builds are both now incorporated into the Sphinx builds and need not be published separately. The rmm docs were published as part of the 23.12 release, so they can also be removed from the stable pages, but libcudf is only being merged this release so only the nightly can be removed. This PR should be merged after rapidsai/cudf#13846.