Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Disable doxygen documentation publication #1372

Closed
vyasr opened this issue Nov 2, 2023 · 6 comments
Closed

[FEA] Disable doxygen documentation publication #1372

vyasr opened this issue Nov 2, 2023 · 6 comments
Assignees
Labels
doc Documentation feature request New feature or request

Comments

@vyasr
Copy link
Contributor

vyasr commented Nov 2, 2023

Is your feature request related to a problem? Please describe.
After #1324 the C++ APIs of rmm are documented within the Sphinx documentation along with the Python APIs. As a result, there is no longer a need for publication of the doxygen docs. However, they were left in place to allow easy comparison during the remainder of the 23.12 development cycle.

Describe the solution you'd like
We should stop publishing the doxygen docs before the release.

@vyasr vyasr added feature request New feature or request ? - Needs Triage Need team to review and classify labels Nov 2, 2023
@ajschmidt8
Copy link
Member

Linking this comment in particular that identify the necessary follow-up tasks

#1324 (review)

@harrism harrism added doc Documentation and removed ? - Needs Triage Need team to review and classify labels Jan 18, 2024
@harrism
Copy link
Member

harrism commented Jan 18, 2024

Hope you don't mind, I'm assigning you @ajschmidt8 and @vyasr. Do you think it's reasonable to finish this in 24.02? We can push to 24.04 if not.

@vyasr
Copy link
Contributor Author

vyasr commented Jan 18, 2024

Yup assigning us is fine. We've already stopped building the doxygen HTML, so I think we should be good to go for this release. Perhaps a website update is still needed though, @ajschmidt8 should I modify rapidsai/docs#464 to just remove rmm and get that merged, then come back to cudf when we remove it?

@harrism
Copy link
Member

harrism commented Mar 6, 2024

@ajschmidt8 @vyasr is this going to happen in 24.04 or should I move to 24.06?

@ajschmidt8
Copy link
Member

As far as I can tell, this was completed in the PRs below:

@vyasr, any remaining items here? or can we close it? I think that should be everything.

@ajschmidt8
Copy link
Member

Confirmed with Vyas offline that it is complete. Closing.

@github-project-automation github-project-automation bot moved this from Todo to Done in RMM Project Board Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation feature request New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants